-
Notifications
You must be signed in to change notification settings - Fork 12
fix: Use CLI tqdm if ipywidgets not installed #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @virrrat, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the progress bar feature was not working as expected in VSCode Jupyter environments when using Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds ipywidgets as a dependency to enable the progress bar feature in notebook environments. While this fixes the immediate issue, I've raised a concern about making a UI-specific library a core dependency for all users. I've suggested an alternative approach using optional dependencies (extras_require) which would be a better design choice, preventing dependency bloat for users who do not use notebook environments.
Use CLI tqdm progress bar when
ipywidgetspackage is not available. This is needed for the per-cell progress bar feature (#129) to work in vscode jupyter env.Earlier error (VS Code):
VS Code:

Colab:
