Skip to content

Conversation

@virrrat
Copy link
Contributor

@virrrat virrrat commented Nov 12, 2025

Use CLI tqdm progress bar when ipywidgets package is not available. This is needed for the per-cell progress bar feature (#129) to work in vscode jupyter env.

Earlier error (VS Code):

ImportError: IProgress not found.

VS Code:
image

Colab:
image

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @virrrat, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the progress bar feature was not working as expected in VSCode Jupyter environments when using dataproc-spark-connect. The change ensures proper functionality by incorporating a necessary library into the project's dependencies, thereby enhancing the user experience for interactive sessions.

Highlights

  • Dependency Addition: The ipywidgets library has been added as a new dependency for the dataproc-spark-connect package.
  • Feature Enablement: This dependency is crucial for enabling the progress bar feature to function correctly within VSCode Jupyter environments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@virrrat virrrat requested review from fangyh20 and medb November 12, 2025 19:25
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds ipywidgets as a dependency to enable the progress bar feature in notebook environments. While this fixes the immediate issue, I've raised a concern about making a UI-specific library a core dependency for all users. I've suggested an alternative approach using optional dependencies (extras_require) which would be a better design choice, preventing dependency bloat for users who do not use notebook environments.

@virrrat virrrat changed the title fix: Install ipywidgets as a dependency for dataproc-spark-connect fix: Use CLI tqdm if ipywidgets not installed Nov 13, 2025
@medb medb merged commit a0d2551 into main Nov 13, 2025
5 checks passed
@medb medb deleted the vscode-progress-bar-fix branch November 13, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants