Skip to content

Conversation

@medb
Copy link
Contributor

@medb medb commented Nov 11, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @medb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on optimizing the project's dependency management by switching to a more lightweight Spark Connect client. Concurrently, it updates the associated unit tests to reflect a more generalized approach to handling Spark SQL data source properties, ensuring compatibility and correctness with the updated client and configuration patterns.

Highlights

  • Dependency Update: The project's dependencies have been updated to use the lightweight pyspark-client package instead of the full pyspark[connect] package. This change is reflected in both requirements-dev.txt and setup.py.
  • Test Refactoring: Unit tests in test_session.py have been refactored to align with changes in Spark Connect configuration property handling. Specifically, assertions related to spark.datasource.bigquery.writeMethod and spark.datasource.bigquery.viewsEnabled have been replaced or removed in favor of the more general spark.sql.sources.default property.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the project's dependencies to use the lightweight pyspark-client instead of the full pyspark[connect], which is a positive change for reducing the package size. The modifications in requirements-dev.txt and setup.py are appropriate. However, my review of tests/unit/test_session.py has identified a critical issue where a test assertion will cause the build to fail due to a logical contradiction. Additionally, another test has been weakened and no longer fully validates the behavior of the code it's supposed to test. Please see my detailed comments for suggestions on how to resolve these issues.

@medb medb changed the title fear: Depend on the lightweight Spark Connect client feat: Depend on the lightweight Spark Connect client Nov 12, 2025
@medb medb merged commit 89d77af into main Nov 12, 2025
5 checks passed
@medb medb deleted the pyspark_dep branch November 12, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants