Add mmjproj model support#14
Add mmjproj model support#14Godzilla675 wants to merge 1 commit intoFix-whisper-initial-download-issuefrom
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the application's compatibility with various projector models by integrating support for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively adds support for mmjproj models by updating the list of recognized projector markers, adjusting the scoring logic in the ModelDownloadService, modifying a user-facing error message, and including a new unit test. The changes are logical and well-contained. I have one minor suggestion to improve the maintainability of the scoring logic.
| if (lowerPath.contains("mmproj") || lowerPath.contains("mmjproj")) { | ||
| score += 1 | ||
| } |
There was a problem hiding this comment.
For better maintainability and readability, consider using a list of markers and the any function. This makes it easier to add more projector markers in the future without extending the if condition.
| if (lowerPath.contains("mmproj") || lowerPath.contains("mmjproj")) { | |
| score += 1 | |
| } | |
| if (listOf("mmproj", "mmjproj").any { lowerPath.contains(it) }) { | |
| score += 1 | |
| } |
There was a problem hiding this comment.
Pull request overview
Adds support for mmjproj projector sidecar naming so these files are recognized as projection artifacts (not standalone models) and are preferred appropriately when auto-selecting/download a projector.
Changes:
- Extend projector marker detection to include
mmjproj. - Update projector sidecar selection scoring to treat
mmjprojlikemmproj. - Update user-facing readiness error text and add a unit test covering
mmjprojfiltering.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/java/com/dark/tool_neuron/repo/ModelStoreRepository.kt | Recognize mmjproj as a projector marker during GGUF filtering. |
| app/src/main/java/com/dark/tool_neuron/service/ModelDownloadService.kt | Score mmjproj files similarly to mmproj when selecting a projector sidecar. |
| app/src/main/java/com/dark/tool_neuron/viewmodel/ChatViewModel.kt | Update the “load projector” error message to mention mmjproj. |
| app/src/test/java/com/dark/tool_neuron/repo/ModelStoreRepositoryTest.kt | Add coverage ensuring mmjproj files are rejected as standalone supported GGUF models. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| private val QUANTIZATION_MATCH_REGEX = Regex("""(?:^|[.-])((?:I?Q)\d+(?:_[A-Z0-9]+)*)""") | ||
| private val TRAILING_QUANTIZATION_REGEX = Regex("""([.-])(?:I?Q)\d+(?:_[A-Z0-9]+)*(?:-[A-Z0-9]+)*$""") | ||
| private val PROJECTOR_MARKERS = listOf("mmproj", "vision-adapter", "projector") | ||
| private val PROJECTOR_MARKERS = listOf("mmproj", "mmjproj", "vision-adapter", "projector") |
There was a problem hiding this comment.
Adding a new projector marker changes the GGUF filtering behavior that feeds the on-disk model store cache. To prevent stale caches from continuing to show *mmjproj*.gguf as selectable models, bump ModelStoreCache.CURRENT_VERSION so existing caches are invalidated as intended by the comment above it.
Added
mmjprojto the list of recognized projector markers to support models that use this extension/naming convention. Updated the ModelDownloadService to givemmjprojfiles the same scoring logic asmmprojfiles when selecting a projector sidecar. Updated the ChatViewModel error message to mentionmmjprojand added a unit test to verify thatmmjprojfiles are correctly identified as projection artifacts rather than standalone models.PR created automatically by Jules for task 5231399183616601442 started by @Godzilla675