Skip to content

enhance reference region models, documentations, and test fixtures #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lykmapipo merged 2 commits into from
Jan 31, 2026
Merged

enhance reference region models, documentations, and test fixtures #51

lykmapipo merged 2 commits into from
Jan 31, 2026

Conversation

@lykmapipo
Copy link
Collaborator

@lykmapipo lykmapipo commented Jan 27, 2026

This:

  • Extend EEZ region model with sovereignty and territory fields
  • Align MPA and RFMO models with latest public API response structure
  • Improve docstrings with latest public API documentation links and data caveats
  • Update tests to validate expanded region fields and mappings

@lykmapipo
feat(references): enhance regions models, fixtures, and documentation
d57c01c 
This:
- enrich EEZ region models with sovereignty and territory fields
- align RFMO and MPA region models with API response structure
- refactor regions imports to use explicit response models
- expand docstrings with official API references and data caveats
- replace inline test data with JSON fixtures for regions
- update tests to validate extended region response fields
@lykmapipo lykmapipo self-assigned this Jan 27, 2026
@lykmapipo lykmapipo added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 27, 2026
@lykmapipo lykmapipo changed the title Enhance reference region models, documentations, and test fixtures enhance reference region models, documentations, and test fixtures Jan 27, 2026
@lykmapipo
chore: streamline formatting and update dependencies
b8e99c2 
This:
- remove Black from Makefile format/lint tasks in favor of Ruff
- align notebook formatting with Ruff-only workflow
- add module-level docstring to Sphinx config
- bump core, dev, test, docs, and notebook dependency versions
aperdizs
aperdizs approved these changes Jan 27, 2026
View reviewed changes
Copy link

@aperdizs aperdizs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lykmapipo lykmapipo merged commit ae63d9b into develop Jan 31, 2026
4 checks passed
@lykmapipo lykmapipo deleted the feature/reference-regions branch January 31, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aperdizs aperdizs aperdizs approved these changes

@giselamo giselamo Awaiting requested review from giselamo

@rrequero rrequero Awaiting requested review from rrequero

@tomaslink tomaslink Awaiting requested review from tomaslink

@yaaNuamahGFW yaaNuamahGFW Awaiting requested review from yaaNuamahGFW

Assignees

@lykmapipo lykmapipo

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lykmapipo @aperdizs