glimpse-GM-GroupNav-6 #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eleton with profile picture, group picture, and group name parameters. Note: no actual button functionality and no dark mode support for menu button
JasonMun7
approved these changes
Jul 2, 2024
Collaborator
JasonMun7
left a comment
JasonMun7
left a comment
There was a problem hiding this comment.
This looks great Andrew! Thanks for adding the function for when they click on the hamburger icon!
Something we might have to keep in mind is that we might have to add more functionality when we get users to be able to access their profile pages. Also we have to think about how we want to convert people's images in order to scale them universally. Other than that it looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added group menu icon svg to assets and created groupnav component skeleton with profile picture, group picture, and group name parameters. Note: no actual button functionality and no dark mode support for menu button