Skip to content

Conversation

@viktorrenkema
Copy link
Contributor

@viktorrenkema viktorrenkema commented Jan 21, 2026

Slack: https://gitbook.slack.com/archives/C01NXGWJELS/p1769021898721909

This should fix the logo resizing likely caused by using the tailwind variant lg:site-header-none:page-no-toc:max-w-56 that relies on a :has() selector looking for .page-no-toc class.

  • yhis class lives on the element which gets replaced during Next.js client-side navigation.
  • during the transition, the old is removed before the new one is mounted, causing a timing gap where :has(.page-no-toc) returns false.
  • since the (with the logo) is preserved across navigations, it temporarily loses access to the page state and reverts to default sizing.

We already have a similar fix for the same problem in site-width-wide, so this pr follows the same pattern by extending PreservePageLayout component to also sync the page-no-toc/page-has-toc class to the

element (which persists across navigations), in turn ensuring the Tailwind variant selector always has access to the correct page state during transitions.

Demo

Before:
Logo shows in 3 different sizes:
CleanShot 2026-01-21 at 20 17 56 2@2x

CleanShot 2026-01-21 at 20 17 10@2x CleanShot 2026-01-21 at 20 17 35@2x

After (couldnt repro it anymore with the current branch, despite it being easy to repro in prod)

CleanShot.2026-01-21.at.20.30.22.mp4

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2026

⚠️ No Changeset found

Latest commit: dac5e9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@argos-ci
Copy link

argos-ci bot commented Jan 21, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) ✅ No changes detected - Jan 21, 2026, 7:36 PM
v2-cloudflare (Inspect) ⚠️ Changes detected (Review) 22 changed Jan 21, 2026, 7:42 PM
v2-vercel (Inspect) ⚠️ Changes detected (Review) 25 changed Jan 21, 2026, 7:42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants