Skip to content

fix: move CORS allowed origins to env variable #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adityapichikala wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −3
Open

fix: move CORS allowed origins to env variable #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e62471
fix: move CORS allowed origins to env variable
adityapichikala May 24, 2026
312d699
fix: harden ALLOWED_ORIGINS parsing to avoid lockout on empty values
adityapichikala May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions backend/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Server
PORT=5000
NODE_ENV=development

# MongoDB
MONGO_URI=mongodb://127.0.0.1:27017/github_tracker

# Session
SESSION_SECRET=your_session_secret_here

# CORS — comma-separated list of allowed frontend origins
# In production, set this to your actual frontend URL(s).
# If not set, defaults to http://localhost:5173
ALLOWED_ORIGINS=http://localhost:5173
12 changes: 9 additions & 3 deletions backend/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,19 @@ const logger = require('./logger');

const app = express();

// CORS configuration
const allowedOrigins = ['http://localhost:5173', 'https://github-spy.etlify.app'];
// CORS configuration — allowed origins are read from the ALLOWED_ORIGINS env var
// (comma-separated). Falls back to localhost for local development.
const parsedOrigins = process.env.ALLOWED_ORIGINS
? process.env.ALLOWED_ORIGINS.split(',').map(origin => origin.trim()).filter(Boolean)
: [];
const allowedOrigins = parsedOrigins.length > 0 ? parsedOrigins : ['http://localhost:5173'];

app.use(cors({
origin: function (origin, callback) {
// Allow requests with no origin (e.g. server-to-server, curl, mobile apps)
if (!origin || allowedOrigins.indexOf(origin) !== -1) {
callback(null, true);
} else{
} else {
callback(new Error('Blocked by CORS policy'));
}
},
Expand Down