Skip to content

fix: improve env setup and prevent malformed auth API URLs #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vv-verse wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve env setup and prevent malformed auth API URLs #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Backend API URL
# Local development
VITE_BACKEND_URL=http://localhost:5000

# Production example
# VITE_BACKEND_URL=https://your-backend-url.onrender.com
8 changes: 8 additions & 0 deletions backend/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# MongoDB connection string
MONGO_URI=mongodb://localhost:27017/github_tracker

# Session secret - use a strong random string
SESSION_SECRET=your_session_secret_here

# Server port
PORT=5000
2 changes: 1 addition & 1 deletion src/pages/Login/Login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useNavigate, Link } from "react-router-dom";
import { ThemeContext } from "../../context/ThemeContext";
import type { ThemeContextType } from "../../context/ThemeContext";

const backendUrl = import.meta.env.VITE_BACKEND_URL;
const backendUrl = import.meta.env.VITE_BACKEND_URL || '';

interface LoginFormData {
email: string;
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Signup/Signup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { User, Mail, Lock, Eye, EyeOff } from "lucide-react";
import { ThemeContext } from "../../context/ThemeContext";
import type { ThemeContextType } from "../../context/ThemeContext";

const backendUrl = import.meta.env.VITE_BACKEND_URL;
const backendUrl = import.meta.env.VITE_BACKEND_URL || '';

interface SignUpFormData {
username: string;
Expand Down
Loading