Skip to content

fix: add id/name attributes and labels to form fields for accessibili… #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ARUSHIGULBHILE wants to merge 1 commit into
base: main
Choose a base branch
from
+76 −24
Open

fix: add id/name attributes and labels to form fields for accessibili… #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 23 additions & 18 deletions src/components/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,24 +93,29 @@ function Footer() {
onSubmit={handleSubscribe}
className="flex flex-col sm:flex-row items-stretch gap-2"
>
<input
type="email"
required
placeholder="Enter email address"
value={email}
onChange={(e) => setEmail(e.target.value)}
className="
flex-grow text-sm px-4 py-3
bg-zinc-50 dark:bg-zinc-800/40
border border-zinc-200 dark:border-zinc-700/50
rounded-xl
focus:outline-none focus:ring-2
focus:ring-blue-500/20 focus:border-blue-500
text-zinc-900 dark:text-white
placeholder-zinc-400 dark:placeholder-zinc-500
transition-all
"
/>
<div className="relative flex-grow">
<label htmlFor="newsletter-email" className="sr-only">Email address</label>
<input
id="newsletter-email"
type="email"
name="email"
required
placeholder="Enter email address"
value={email}
onChange={(e) => setEmail(e.target.value)}
className="
w-full text-sm px-4 py-3
bg-zinc-50 dark:bg-zinc-800/40
border border-zinc-200 dark:border-zinc-700/50
rounded-xl
focus:outline-none focus:ring-2
focus:ring-blue-500/20 focus:border-blue-500
text-zinc-900 dark:text-white
placeholder-zinc-400 dark:placeholder-zinc-500
transition-all
"
/>
</div>

<button
type="submit"
Expand Down
14 changes: 13 additions & 1 deletion src/pages/Contact/Contact.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ function Contact() {
{/* Full Name */}
<div>
<label
htmlFor="fullname"
className={`block text-xs font-medium mb-1 ${
mode === "dark"
? "text-gray-300"
Expand All @@ -217,6 +218,8 @@ function Contact() {
Full Name
</label>
<input
id="fullname"
name="fullname"
type="text"
placeholder="Enter your full name"
required
Expand All @@ -231,6 +234,7 @@ function Contact() {
{/* Email */}
<div>
<label
htmlFor="email"
className={`block text-xs font-medium mb-1 ${
mode === "dark"
? "text-gray-300"
Expand All @@ -240,6 +244,8 @@ function Contact() {
Email Address
</label>
<input
id="email"
name="email"
type="email"
placeholder="your.email@example.com"
required
Expand All @@ -254,6 +260,7 @@ function Contact() {
{/* Subject */}
<div>
<label
htmlFor="subject"
className={`block text-xs font-medium mb-1 ${
mode === "dark"
? "text-gray-300"
Expand All @@ -263,6 +270,8 @@ function Contact() {
Subject
</label>
<select
id="subject"
name="subject"
className={`w-full p-2 sm:p-3 rounded-lg sm:rounded-xl text-sm sm:text-base transition-all duration-300 focus:outline-none focus:ring-2 focus:ring-purple-500 ${
mode === "dark"
? "bg-white/5 border border-white/20 text-white placeholder-gray-400"
Expand All @@ -284,6 +293,7 @@ function Contact() {
{/* Message */}
<div className="relative">
<label
htmlFor="message"
className={`block text-xs font-medium mb-1 ${
mode === "dark"
? "text-gray-300"
Expand All @@ -293,6 +303,8 @@ function Contact() {
Message
</label>
<textarea
id="message"
name="message"
placeholder="Type your message here..."
required
rows={4}
Expand Down Expand Up @@ -348,4 +360,4 @@ function Contact() {
);
}

export default Contact;
export default Contact;
4 changes: 4 additions & 0 deletions src/pages/Login/Login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ const Login: React.FC = () => {

<form onSubmit={handleSubmit} className="space-y-6">
<div className="relative">
<label htmlFor="email" className="sr-only">Email address</label>
<input
id="email"
type="email"
name="email"
placeholder="Enter your email"
Expand All @@ -107,7 +109,9 @@ const Login: React.FC = () => {
</div>

<div className="relative">
<label htmlFor="password" className="sr-only">Password</label>
<input
id="password"
type="password"
name="password"
autoComplete="current-password"
Expand Down
36 changes: 32 additions & 4 deletions src/pages/Signup/Signup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,18 @@ const SignUp: React.FC = () => {
<form onSubmit={handleSubmit} className="space-y-6">
<div>
<div className="relative">
<label htmlFor="username" className="sr-only">Username</label>
<div className="absolute inset-y-0 left-0 pl-4 flex items-center pointer-events-none">
<User className="h-5 w-5 text-gray-400" />
</div>
<input type="text" name="username" placeholder="Enter your username" value={formData.username} onChange={handleChange} required
<input
id="username"
type="text"
name="username"
placeholder="Enter your username"
value={formData.username}
onChange={handleChange}
required
className={`w-full pl-12 pr-4 py-4 rounded-2xl border focus:outline-none focus:ring-2 focus:ring-gray-400 focus:border-transparent transition-all duration-300 ${mode === "dark" ? "bg-white/10 border-white/20 text-white placeholder-gray-400" : "bg-gray-100 border-gray-300 text-black placeholder-gray-400"}`}
/>
</div>
Expand All @@ -178,10 +186,18 @@ const SignUp: React.FC = () => {

<div>
<div className="relative">
<label htmlFor="email" className="sr-only">Email</label>
<div className="absolute inset-y-0 left-0 pl-4 flex items-center pointer-events-none">
<Mail className="h-5 w-5 text-gray-400" />
</div>
<input type="email" name="email" placeholder="Enter your email" value={formData.email} onChange={handleChange} required
<input
id="email"
type="email"
name="email"
placeholder="Enter your email"
value={formData.email}
onChange={handleChange}
required
className={`w-full pl-12 pr-4 py-4 rounded-2xl border focus:outline-none focus:ring-2 focus:ring-gray-400 focus:border-transparent transition-all duration-300 ${mode === "dark" ? "bg-white/10 border-white/20 text-white placeholder-gray-400" : "bg-gray-100 border-gray-300 text-black placeholder-gray-400"}`}
/>
</div>
Expand All @@ -190,13 +206,25 @@ const SignUp: React.FC = () => {

<div>
<div className="relative">
<label htmlFor="password" className="sr-only">Password</label>
<div className="absolute inset-y-0 left-0 pl-4 flex items-center pointer-events-none">
<Lock className="h-5 w-5 text-gray-400" />
</div>
<input type={showPassword ? "text" : "password"} name="password" placeholder="Enter your password" value={formData.password} onChange={handleChange} required
<input
id="password"
type={showPassword ? "text" : "password"}
name="password"
placeholder="Enter your password"
value={formData.password}
onChange={handleChange}
required
className={`w-full pl-12 pr-12 py-4 rounded-2xl border focus:outline-none focus:ring-2 focus:ring-gray-400 focus:border-transparent transition-all duration-300 ${mode === "dark" ? "bg-white/10 border-white/20 text-white placeholder-gray-400" : "bg-gray-100 border-gray-300 text-black placeholder-gray-400"}`}
/>
<button type="button" onClick={() => setShowPassword(!showPassword)} aria-label={showPassword ? "Hide password" : "Show password"} aria-pressed={showPassword}
<button
type="button"
onClick={() => setShowPassword(!showPassword)}
aria-label={showPassword ? "Hide password" : "Show password"}
aria-pressed={showPassword}
className={`absolute inset-y-0 right-0 pr-4 flex items-center transition-colors duration-200 ${mode === "dark" ? "text-slate-400 hover:text-white" : "text-gray-500 hover:text-gray-800"}`}>
{showPassword ? <EyeOff className="h-5 w-5" /> : <Eye className="h-5 w-5" />}
</button>
Expand Down
5 changes: 4 additions & 1 deletion src/pages/Tracker/Tracker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,9 @@ const Home: React.FC = () => {
<FormControl sx={{ minWidth: 150 }}>
<InputLabel sx={{ fontSize: "14px" }}>State</InputLabel>
<Select
id="state-select"
name="state-select"
autoComplete="off"
value={tab === 0 ? issueFilter : prFilter}
onChange={(e) =>
tab === 0
Expand All @@ -320,7 +323,7 @@ const Home: React.FC = () => {
<MenuItem value="open">Open</MenuItem>
<MenuItem value="closed">Closed</MenuItem>
{tab === 1 && <MenuItem value="merged">Merged</MenuItem>}
</Select>
</Select>
</FormControl>
</Box>

Expand Down
Loading