Skip to content

fix: improve type safety in Signup.tsx error handling #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jai-Shankar1033 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −8
Open

fix: improve type safety in Signup.tsx error handling #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/pages/Signup/Signup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,17 +83,20 @@ const SignUp: React.FC = () => {
}
setIsLoading(true);
try {
const response = await axios.post(`${backendUrl}/api/auth/signup`,
formData // Include cookies for session
);
setMessage(response.data.message); // Show success message from backend

// Navigate to login page after successful signup
const response = await axios.post(`${backendUrl}/api/auth/signup`, formData);
setMessage(response.data.message);
if (response.data.message === 'User created successfully') {
navigate("/login");
}
} catch (error: any) {
setMessage(error.response?.data?.message || "Something went wrong. Please try again.");
} catch (error: unknown) {
if (axios.isAxiosError(error)) {
setMessage(
(error.response?.data as { message?: string })?.message ??
"Something went wrong. Please try again."
);
} else {
setMessage("Something went wrong. Please try again.");
}
} finally {
setIsLoading(false);
}
Expand Down
Loading