Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@
#include "Framework/runDataProcessing.h"
#include "ReconstructionDataFormats/Track.h"

#include "TDatabasePDG.h"

Check failure on line 47 in PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/database]

Do not use TDatabasePDG directly. Use o2::constants::physics::Mass... or Service<o2::framework::O2DatabasePDG> instead.
#include "TPDGCode.h"

#include <cstdint>
#include <cstring>
#include <string>
#include <numeric>
#include <random>
#include <string>
#include <unordered_map>
#include <utility>
#include <vector>
Expand Down Expand Up @@ -365,10 +365,10 @@
track.itsNCls() < track_nClsItsMin ||
track.tpcNClsFound() < track_nClsTpcMin ||
track.tpcNClsCrossedRows() < track_nClsTpcMin ||
track.tpcNClsCrossedRows() < 0.8 * track.tpcNClsFindable() ||

Check failure on line 368 in PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
track.tpcNClsShared() > track_nClsTpcMaxShared ||
track.tpcChi2NCl() < track_tpcChi2Min ||
track.tpcChi2NCl() > 4.0f) {

Check failure on line 371 in PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
}
return true;
Expand Down Expand Up @@ -797,7 +797,7 @@
}

LOG(info) << "Bethe-Bloch parameters for He3:";
for (int i = 0; i < 5; i++) {

Check failure on line 800 in PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
m_BBparamsHe[i] = setting_BetheBlochParams->get("He3", Form("p%i", i));
LOG(info) << "p" << i << ": " << m_BBparamsHe[i];
}
Expand Down Expand Up @@ -1272,7 +1272,7 @@
const auto& posTracks_thisCollision = posTracks.sliceByCached(o2::aod::track::collisionId, collision.globalIndex(), m_cache);
const auto& negTracks_thisCollision = negTracks.sliceByCached(o2::aod::track::collisionId, collision.globalIndex(), m_cache);

for (auto& [posTrack, negTrack] : o2::soa::combinations(o2::soa::CombinationsFullIndexPolicy(posTracks_thisCollision, negTracks_thisCollision))) {

Check failure on line 1275 in PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
fillElectronTable(posTrack, negTrack);
}
}
Expand All @@ -1289,7 +1289,7 @@

m_hAnalysis.fill(HIST("zVtx"), collision.posZ());

for (auto track : tracks) {

Check failure on line 1292 in PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
if (!qualityTrackSelection(track)) {
return;
}
Expand All @@ -1314,7 +1314,7 @@

m_hAnalysis.fill(HIST("zVtx"), collision.posZ());

for (auto track : tracks) {

Check failure on line 1317 in PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
if (!qualityTrackSelection(track)) {
return;
}
Expand Down Expand Up @@ -1346,11 +1346,11 @@
cascTable_thisCollision.bindExternalIndices(&v0s);

m_v0TrackParCovs.clear();
for (auto& v0 : v0Table_thisCollision) {

Check failure on line 1349 in PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
fillV0Cand</*isMC*/ true>(PV, v0, tracks);
}

for (auto& cascade : cascTable_thisCollision) {

Check failure on line 1353 in PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
fillKCand</*isMC*/ true>(PV, cascade, tracks);
}
}
Expand Down Expand Up @@ -1396,7 +1396,7 @@
initCCDB(bc);
m_hAnalysis.fill(HIST("zVtx"), collision.posZ());

for (auto track : tracks) {

Check failure on line 1399 in PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
if (!qualityTrackSelection(track)) {
return;
}
Expand Down
Loading