Skip to content

⚡ Optimize regex compilation in tcp_client.py #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GhostTypes merged 1 commit into from
Jan 20, 2026
Merged

⚡ Optimize regex compilation in tcp_client.py #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions flashforge/tcp/tcp_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,16 @@

import asyncio
import logging
import re
from typing import List, Optional

from .gcode.gcodes import GCodes

logger = logging.getLogger(__name__)

# Regex for invalid characters in filenames
INVALID_FILENAME_CHARS_PATTERN = re.compile(r'[^\w\s\-\.\(\)\+%,@\[\]{}:;!#$^&*=<>?\/]')


class FlashForgeTcpClient:
"""
Expand Down Expand Up @@ -416,8 +420,7 @@ def _parse_file_list_response(self, response: str) -> List[str]:
filename = full_path[6:] # Remove '/data/' prefix

# Trim at the first invalid character (if any)
import re
match = re.search(r'[^\w\s\-\.\(\)\+%,@\[\]{}:;!#$^&*=<>?\/]', filename)
match = INVALID_FILENAME_CHARS_PATTERN.search(filename)
if match:
filename = filename[:match.start()]

Expand Down