Feature/cms13 upgrade#31
Open
drazenstankovic wants to merge 3 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the target framework to .NET 10.0, updates several package dependencies, replaces Newtonsoft.Json with System.Text.Json, and introduces a custom Regex-based HTML stripping method. Critical feedback has been provided regarding the change from FilteredItems to Items in ContentAreaExtensions, which bypasses authorization and publishing checks. Additionally, there are performance concerns regarding the instantiation of JsonSerializerOptions on every call in JsonExtensions, and a potential ReDoS vulnerability in StringExtensions due to the lack of a regex timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for cms 13 and commerce 15