[DO NOT MERGE] feat: macos system audio mixing #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SystemAudioCapturer class using ScreenCaptureKit (macOS 13.0+) - Add SystemAudioMixer to mix system audio with microphone audio - Integrate system audio capture into getDisplayMedia when audio: true - Uses ring buffer for efficient audio sample handling - Supports volume control for system and microphone audio Usage: Pass audio: true in getDisplayMedia constraints to capture system audio and mix it into the microphone audio stream.
System audio is now captured and mixed by default when using getDisplayMedia on macOS. To disable, explicitly pass audio: false in constraints.
AudioBufferList has a variable-length array that only has space for 1 buffer when declared on the stack. ScreenCaptureKit provides stereo audio which needs 2 buffers, causing error -12737 (kCMSampleBufferError_ArrayTooSmall). Fix: Dynamically allocate AudioBufferList with space for 2 buffers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.