Respect video scaling in VideoRenderer#321
Open
zhs852 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fix VideoRenderer in the Compose artifact so videoScalingType is respected when the composable is measured with fixed or fill constraints, such as Modifier.fillMaxSize().
Previously, VideoRenderer passed the scaling type to VideoTextureViewRenderer, but Compose AndroidView constraints could still force the renderer to occupy the full parent size. In that case SCALE_ASPECT_FIT behaved like a filled or cropped render instead of preserving the video aspect ratio with letterboxing.
🛠 Implementation details
VideoRenderer now wraps the underlying AndroidView in BoxWithConstraints, tracks the latest rendered frame size from RendererEvents.onFrameResolutionChanged, and computes the renderer view size with RendererCommon.getDisplaySize(...) using the requested VideoScalingType.