-
Notifications
You must be signed in to change notification settings - Fork 58
Add RingingCallJoinInterceptor hook for ringing call activation #1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rahul-lohra
wants to merge
16
commits into
develop
Choose a base branch
from
feature/rahullohra/call-join-interception-2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ae95ca2
feat: add RingingCallJoinInterceptor
rahul-lohra 85d5912
feat: remove dead code
rahul-lohra a0af125
feat: update test cases
rahul-lohra 8eeb149
feat: update logic to run in parallel
rahul-lohra eda3192
feat: remove DefaultRingingCallJoinInterceptor
rahul-lohra 568fc81
chore: refactor the interface name
rahul-lohra 92c2769
feat: Introduce Call Join Interceptor
rahul-lohra 65ce77d
chore: improve direct call screen ui
rahul-lohra e5f3f10
chore: remove logs, remove testing timeouts
rahul-lohra 2d469a3
chore: minor improvements
rahul-lohra 2fd3023
chore: add unit tests
rahul-lohra b7382fe
chore: refactor
rahul-lohra 31880c9
chore: refactor
rahul-lohra 48d6ac8
Merge branch 'develop' into feature/rahullohra/call-join-interception-2
rahul-lohra 0054308
chore: refactor
rahul-lohra 3943d33
fix: disable USE_CALL_JOIN_INTERCEPTOR by default
rahul-lohra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
demo-app/src/main/kotlin/io/getstream/video/android/DemoCallJoinInterceptor.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Copyright (c) 2014-2026 Stream.io Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Stream License; | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://github.com/GetStream/stream-video-android/blob/main/LICENSE | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.getstream.video.android | ||
|
|
||
| import io.getstream.log.taggedLogger | ||
| import io.getstream.video.android.CallActivity.Companion.USE_CALL_JOIN_INTERCEPTOR | ||
| import io.getstream.video.android.core.Call | ||
| import io.getstream.video.android.core.CallJoinInterceptor | ||
| import io.getstream.video.android.core.RingingState | ||
| import kotlinx.coroutines.flow.filter | ||
| import kotlinx.coroutines.flow.first | ||
|
|
||
| /** | ||
| * Do the following changes before testing this flow | ||
| * Set [io.getstream.video.android.core.INTERCEPTOR_TIMEOUT_MS] to 10_000L | ||
| * Set [io.getstream.video.android.core.PEER_CONNECTION_OBSERVER_TIMEOUT] to 10_000L | ||
| */ | ||
| class DemoCallJoinInterceptor( | ||
| private val previousRingingStates: Set<RingingState>, | ||
| ) : CallJoinInterceptor { | ||
| private val logger by taggedLogger("DemoCallJoinInterceptor") | ||
|
|
||
| companion object { | ||
| const val CALLER_READY_TO_JOIN_EVENT_TYPE = "caller_ready_join" | ||
| const val CALLEE_READY_TO_JOIN_EVENT_TYPE = "callee_ready_join" | ||
| } | ||
|
|
||
| override suspend fun callReadyToJoin(call: Call) { | ||
| if (USE_CALL_JOIN_INTERCEPTOR) { | ||
| val isIncomingOrOutgoing = previousRingingStates.firstOrNull { | ||
| it is RingingState.Incoming || it is RingingState.Outgoing | ||
| } | ||
|
|
||
| val isOutgoing = isIncomingOrOutgoing is RingingState.Outgoing | ||
| val isIncoming = isIncomingOrOutgoing is RingingState.Incoming | ||
|
|
||
| val currentUserId = call.user.id | ||
| if (isIncoming) { | ||
| val result = call.sendCustomEvent( | ||
| mapOf( | ||
| "type" to CALLEE_READY_TO_JOIN_EVENT_TYPE, | ||
| "user_id" to currentUserId, | ||
| ), | ||
| ) | ||
| if (result.isSuccess) { | ||
| logger.d { "[callReadyToJoin] Successfully sent custom $CALLEE_READY_TO_JOIN_EVENT_TYPE event" } | ||
| App.demoApp.callerReadyToJoinFlow.filter { it != null && it.callCid == call.cid }.first() | ||
| } else { | ||
| logger.d { "[callReadyToJoin] Failed to send custom $CALLEE_READY_TO_JOIN_EVENT_TYPE event" } | ||
| } | ||
| logger.d { "[callReadyToJoin] callerReadyToJoinFlow finish" } | ||
| } else if (isOutgoing) { | ||
| val result = call.sendCustomEvent( | ||
| mapOf( | ||
| "type" to CALLER_READY_TO_JOIN_EVENT_TYPE, | ||
| "user_id" to currentUserId, | ||
| ), | ||
| ) | ||
|
|
||
| if (result.isSuccess) { | ||
| logger.d { "[callReadyToJoin] Successfully sent custom $CALLER_READY_TO_JOIN_EVENT_TYPE event" } | ||
| App.demoApp.calleeReadyToJoinFlow.filter { it != null && it.callCid == call.cid }.first() | ||
| } else { | ||
| logger.d { "[callReadyToJoin] Failed to send custom $CALLER_READY_TO_JOIN_EVENT_TYPE event" } | ||
| } | ||
| logger.d { "[callReadyToJoin] calleeReadyToJoinFlow finish" } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.