-
Notifications
You must be signed in to change notification settings - Fork 58
Add RingingCallJoinInterceptor hook for ringing call activation #1669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+343
−120
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ae95ca2
feat: add RingingCallJoinInterceptor
rahul-lohra 85d5912
feat: remove dead code
rahul-lohra a0af125
feat: update test cases
rahul-lohra 8eeb149
feat: update logic to run in parallel
rahul-lohra eda3192
feat: remove DefaultRingingCallJoinInterceptor
rahul-lohra 568fc81
chore: refactor the interface name
rahul-lohra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
...-core/src/main/kotlin/io/getstream/video/android/core/RingingCallActivationInterceptor.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /* | ||
| * Copyright (c) 2014-2026 Stream.io Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Stream License; | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://github.com/GetStream/stream-video-android/blob/main/LICENSE | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.getstream.video.android.core | ||
|
|
||
| /** | ||
| * Controls when a ringing call transitions to [RingingState.Active]. | ||
| * | ||
| * Implement this to insert custom logic (e.g. waiting for user confirmation) between | ||
| * the publisher peer connection becoming ready and the call going active. | ||
| * Has no effect on non-ringing joins (livestream, direct join). | ||
| */ | ||
| public interface RingingCallActivationInterceptor { | ||
|
Check warning on line 26 in stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/RingingCallActivationInterceptor.kt
|
||
|
|
||
| /** | ||
| * Called when the SDK is ready to transition to [RingingState.Active]. | ||
| * Suspend here to delay the transition; return to allow it to proceed. | ||
| * | ||
| * The SDK enforces a 5-second maximum — the transition proceeds automatically on timeout. | ||
| */ | ||
| public suspend fun callReadyToActivateWithTimeout(call: Call) | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call.join()writesringingCallJoinInterceptoronCallState, but it's never cleared after the transition completes. Integrator interceptors typically capture UI/Activity context in lambdas — for a long-livedCallthis is a real retention path past the join.