Skip to content

[WIP] Improve ringing state transition to Active when WS is not connected#1617

Draft
rahul-lohra wants to merge 1 commit intodevelopfrom
bugfix/rahullohra/join-and-ring-issues
Draft

[WIP] Improve ringing state transition to Active when WS is not connected#1617
rahul-lohra wants to merge 1 commit intodevelopfrom
bugfix/rahullohra/join-and-ring-issues

Conversation

@rahul-lohra
Copy link
Contributor

Goal

Improve Ringing state transition to Active when WS is not connected during joinAndRing

Implementation

If the WebSocket connection is not established during joinAndRing, the caller remains in RingingState.Outgoing. Once the receiver accepts the call, the caller must transition to RingingState.Active to reflect the active call state correctly.

🎨 UI Changes

Add relevant screenshots

Before After
img img

Add relevant videos

Todo

Testing

  1. Return null from private suspend fun waitForConnectionId() to simulate the behaviour when WS is not established
  2. Open DirectCallScreen and ensure joinAndRing checkbox is checked
  3. Test it on 1-1 calls and group calls

…ctive when we perform joinAndRing and WS is not connected

To set WS connection to null set the return of waitForConnectionId to null
@rahul-lohra rahul-lohra self-assigned this Feb 13, 2026
@rahul-lohra rahul-lohra added the pr:improvement Enhances an existing feature or code label Feb 13, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@rahul-lohra rahul-lohra changed the title Improve ringing state transition to Active when WS is not connected during joinAndRing Improve ringing state transition to Active when WS is not connected Feb 13, 2026
@rahul-lohra rahul-lohra changed the title Improve ringing state transition to Active when WS is not connected [WIP] Improve ringing state transition to Active when WS is not connected Feb 13, 2026
@rahul-lohra rahul-lohra changed the title [WIP] Improve ringing state transition to Active when WS is not connected [AND-1065] [WIP] Improve ringing state transition to Active when WS is not connected Feb 13, 2026
@rahul-lohra rahul-lohra changed the title [AND-1065] [WIP] Improve ringing state transition to Active when WS is not connected [WIP] Improve ringing state transition to Active when WS is not connected Feb 13, 2026
@github-actions
Copy link
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 12.00 MB 12.00 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.27 MB 6.28 MB 0.02 MB 🟢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:improvement Enhances an existing feature or code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant