[WIP] Improve ringing state transition to Active when WS is not connected#1617
Draft
rahul-lohra wants to merge 1 commit intodevelopfrom
Draft
[WIP] Improve ringing state transition to Active when WS is not connected#1617rahul-lohra wants to merge 1 commit intodevelopfrom
rahul-lohra wants to merge 1 commit intodevelopfrom
Conversation
…ctive when we perform joinAndRing and WS is not connected To set WS connection to null set the return of waitForConnectionId to null
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Improve Ringing state transition to Active when WS is not connected during joinAndRing
Implementation
If the WebSocket connection is not established during
joinAndRing, the caller remains in RingingState.Outgoing. Once the receiver accepts the call, the caller must transition toRingingState.Activeto reflect the active call state correctly.🎨 UI Changes
Add relevant screenshots
Add relevant videos
Todo
Testing
nullfromprivate suspend fun waitForConnectionId()to simulate the behaviour when WS is not establishedjoinAndRingcheckbox is checked