-
Notifications
You must be signed in to change notification settings - Fork 14
TY linting (replaces mypi) #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "setup-worktree": [ | ||
| "npm install" | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,10 +29,10 @@ pre-commit install | |
|
|
||
| ### Check | ||
|
|
||
| Shortcut to ruff, mypy and non integration tests: | ||
| Shortcut to ruff, ty (type checker) and non integration tests: | ||
|
|
||
| ``` | ||
| uv run python dev.py check | ||
| uv run python dev.py | ||
| ``` | ||
|
Comment on lines
+32
to
36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor grammar and markdown lint issues.
Suggested fix-Shortcut to ruff, ty (type checker) and non integration tests:
+Shortcut to ruff, ty (type checker) and non-integration tests:
-```
+```bash
uv run python dev.py🧰 Tools🪛 LanguageTool[grammar] ~32-~32: Use a hyphen to join words. (QB_NEW_EN_HYPHEN) 🪛 markdownlint-cli2 (0.18.1)34-34: Fenced code blocks should have a language specified (MD040, fenced-code-language) 🤖 Prompt for AI Agents |
||
|
|
||
| ### Formatting | ||
|
|
@@ -41,10 +41,17 @@ uv run python dev.py check | |
| uv run ruff check --fix | ||
| ``` | ||
|
|
||
| ### Mypy type checks | ||
| ### Type checking (ty) | ||
|
|
||
| Type checking is run via the `ty` type checker, excluding generated code: | ||
|
|
||
| ``` | ||
| uv run python dev.py ty | ||
| ``` | ||
|
|
||
| Or manually (note: requires exclude flags for generated code - see dev.py for the full list): | ||
| ``` | ||
| uv run mypy --install-types --non-interactive --exclude 'getstream/models/.*' . | ||
| uvx ty check getstream/ --exclude "getstream/models/" --exclude "getstream/video/rtc/pb/" ... | ||
| ``` | ||
|
Comment on lines
+44
to
55
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add language specifiers to code blocks. Static analysis indicates the code blocks are missing language specifiers for proper syntax highlighting. Suggested fix ### Type checking (ty)
Type checking is run via the `ty` type checker, excluding generated code:
-```
+```bash
uv run python dev.py tyOr manually (note: requires exclude flags for generated code - see dev.py for the full list): 🧰 Tools🪛 markdownlint-cli2 (0.18.1)48-48: Fenced code blocks should have a language specified (MD040, fenced-code-language) 53-53: Fenced code blocks should have a language specified (MD040, fenced-code-language) 🤖 Prompt for AI Agents |
||
|
|
||
| ## Release | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: GetStream/stream-py
Length of output: 469
🏁 Script executed:
Repository: GetStream/stream-py
Length of output: 453
Replace
npm installwith appropriate Python setup command.This is a Python project with no Node.js dependencies. The worktree setup should use
uv installorpip install -e .instead. Currently,npm installwill fail since there's nopackage.jsonin the repository, breaking the Cursor IDE worktree setup for this project.🤖 Prompt for AI Agents