Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
WalkthroughThis PR updates the stream-build-conventions-android dependency from version 0.11.0 to 0.12.1 across Gradle and GitHub Actions workflows. It adds Dependabot grouping for convention updates, adjusts workflow permissions, and wires a Slack webhook secret into the release workflow. ChangesStream Build Conventions Upstream Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/android.yml (1)
21-21: ⚡ Quick winPrefer pinning reusable workflow refs to a commit SHA (not a mutable tag).
Using
@v0.12.1works, but tags can be moved. This PR updates multiple reusable workflow refs across.github/workflows/android.yml,.github/workflows/pr-clean-stale.yaml,.github/workflows/pr-quality.yml, and.github/workflows/publish-new-version.yml—all currently pinned to the same mutable tag. Pinning these to their corresponding immutable commit SHAs hardens CI supply-chain security with minimal effort.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/android.yml at line 21, The workflow currently pins the reusable workflow ref using a mutable tag ("uses: GetStream/stream-build-conventions-android/.github/workflows/android-ci.yml@v0.12.1"); update this to the corresponding immutable commit SHA for that reusable workflow (replace the `@v0.12.1` suffix with the exact commit SHA) and apply the same change to the other workflow files referenced (pr-clean-stale.yaml, pr-quality.yml, publish-new-version.yml) so all "uses: GetStream/stream-build-conventions-android/…@<tag>" entries are pinned to their commit SHAs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/android.yml:
- Line 21: The workflow currently pins the reusable workflow ref using a mutable
tag ("uses:
GetStream/stream-build-conventions-android/.github/workflows/android-ci.yml@v0.12.1");
update this to the corresponding immutable commit SHA for that reusable workflow
(replace the `@v0.12.1` suffix with the exact commit SHA) and apply the same
change to the other workflow files referenced (pr-clean-stale.yaml,
pr-quality.yml, publish-new-version.yml) so all "uses:
GetStream/stream-build-conventions-android/…@<tag>" entries are pinned to their
commit SHAs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 8c522a51-7afc-4f6a-a386-19eab2bf20d0
📒 Files selected for processing (6)
.github/dependabot.yml.github/workflows/android.yml.github/workflows/pr-clean-stale.yaml.github/workflows/pr-quality.yml.github/workflows/publish-new-version.ymlgradle/libs.versions.toml
|



Goal
Pick up build-conventions v0.12.1. v0.12.0 made
slack-webhook-urla required input onrelease.yml; v0.12.1 dropped an unusedissues: writepermission from a few reusable workflows. Also onboard this repo to Dependabot forstream-build-conventions-android, with all bumps grouped into one PR.Implementation
.github/dependabot.ymlcovering gradle + github-actions, withgroups.stream-conventionson each.issues: writefrom PR-quality and stale-PR cleanup workflows.streamConventions0.11.0 → 0.12.1 ingradle/libs.versions.toml.GetStream/stream-build-conventions-android/.github/workflows/...@v0.11.0refs →@v0.12.1.slack-webhook-url: ${{ secrets.SLACK_WEBHOOK_ANDROID_CICD }}torelease.ymlinpublish-new-version.yml.Testing
Checklist
Summary by CodeRabbit