Skip to content

Conversation

@nijeesh-stream
Copy link
Contributor

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Changes

  1. Fixed query_reminders API call to use filter parameter instead of filter_conditions
  2. Enhanced test assertions to verify filter results actually match criteria
  3. Added new test case for message_id filter verification

Why

  • The API expects the parameter name filter, not filter_conditions
  • Previous tests only checked API success, not that filters actually worked
  • This ensures both code correctness and test quality

Testing

  • ✅ All 3 test cases pass (query reminders, channel filter, message_id filter)
  • ✅ Tests now verify returned data matches filter criteria
  • ✅ Manually verified with production staging credentials

@nijeesh-stream nijeesh-stream enabled auto-merge (squash) November 19, 2025 17:47
@nijeesh-stream nijeesh-stream merged commit a7cdd5b into master Nov 19, 2025
6 of 7 checks passed
@nijeesh-stream nijeesh-stream deleted the fix_reminders_query branch November 19, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants