Skip to content

Conversation

@nijeesh-stream
Copy link
Contributor

Submit a pull request

CLA

  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

  • Added the reminders feature
    • added create reminders
    • added delete reminders
    • added query reminders
    • added update reminders
  • In the Makefile added targets to run the tests and linting in docker

  * `create_reminder`: Create a reminder for a message
  * `update_reminder`: Update an existing reminder
  * `delete_reminder`: Delete a reminder
  * `query_reminders`: Query reminders with filtering options
* Add Docker-based development commands to CONTRIBUTING.md
* Create Makefile with development, testing, and Docker-related targets
* Include support for customizable Ruby version and Stream Chat URL
* Add convenience commands for linting, testing, and type checking
@channel_id = SecureRandom.uuid
@channel = @client.channel('messaging', channel_id: @channel_id)
@channel.create('john')
@channel.update_partial({config_overrides: {user_message_reminders: true}})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

Suggested change
@channel.update_partial({config_overrides: {user_message_reminders: true}})
@channel.update_partial({ config_overrides: {user_message_reminders: true}})

@channel_id = SecureRandom.uuid
@channel = @client.channel('messaging', channel_id: @channel_id)
@channel.create('john')
@channel.update_partial({config_overrides: {user_message_reminders: true}})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside { missing.

Suggested change
@channel.update_partial({config_overrides: {user_message_reminders: true}})
@channel.update_partial({config_overrides: { user_message_reminders: true}})

@channel_id = SecureRandom.uuid
@channel = @client.channel('messaging', channel_id: @channel_id)
@channel.create('john')
@channel.update_partial({config_overrides: {user_message_reminders: true}})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

Suggested change
@channel.update_partial({config_overrides: {user_message_reminders: true}})
@channel.update_partial({config_overrides: {user_message_reminders: true }})

@channel_id = SecureRandom.uuid
@channel = @client.channel('messaging', channel_id: @channel_id)
@channel.create('john')
@channel.update_partial({config_overrides: {user_message_reminders: true}})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [rubocop] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog 🐶
Space inside } missing.

Suggested change
@channel.update_partial({config_overrides: {user_message_reminders: true}})
@channel.update_partial({config_overrides: {user_message_reminders: true} })

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants