-
Notifications
You must be signed in to change notification settings - Fork 292
fix: remove Channel component propagation #2904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Size Change: -911 B (-0.32%) Total Size: 283 kB
ℹ️ View Unchanged
|
oliverlaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to adjust the docs too
Yes, that's the next step as discussed earlier. :) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2904 +/- ##
==========================================
+ Coverage 80.00% 80.03% +0.03%
==========================================
Files 506 506
Lines 10777 10776 -1
Branches 2709 2709
==========================================
+ Hits 8622 8625 +3
+ Misses 1902 1898 -4
Partials 253 253 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| <ChatView.Selector /> | ||
| <ChatView.Channels> | ||
| <ChannelList | ||
| Avatar={ChannelAvatar} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arnautov-anton don't we want to apply the same logic to ChannelList? I mean to not to allow passing Components as props and force the use of WithComponents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I can adjust the PR to include .ChannelList too
Edit: I'll open up separate PR to include renames to the ChannelList-related components.
🎯 Goal
Use the capabilities of
WithComponentsto propagate component overrides, do not useChannelas a proxy.BREAKING CHANGE:
Channelcomponent no longer supports component overrides, useWithComponentsinstead.