Add Compose snapshot tests for redesigned components#6424
Draft
Add Compose snapshot tests for redesigned components#6424
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
9c7c249 to
fa0978a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Goal
Backfill Paparazzi snapshot coverage for Compose components introduced during the
redesigned. Also fixed the typing dot indicator's animation not being deterministic in snapshot
tests.
Implementation
StreamButton,CountBadge,MessageReactions,QuotedMessage.MessageFooterTestwith an outgoing thread-start case to cover theMessageAlignment.Endvariant of
MessageThreadFooter.System.currentTimeMillis()inTypingDrawablewith aValueAnimator. The drawable nowimplements
Animatableand starts/stops viaDrawable.setVisible, the standard hookImageViewalready calls on attach/detach/visibility changes. Add Paparazzi's
InstantAnimationsRuletoPaparazziViewTestso the animator settles to a deterministic frame in tests.Testing
verifyPaparazziDebug.frame the typing indicator. Re-running
verifyPaparazziDebugshould no longer produces drift.