Skip to content

Add Compose snapshot tests for redesigned components#6424

Draft
gpunto wants to merge 3 commits intodevelopfrom
screenshot-tests
Draft

Add Compose snapshot tests for redesigned components#6424
gpunto wants to merge 3 commits intodevelopfrom
screenshot-tests

Conversation

@gpunto
Copy link
Copy Markdown
Contributor

@gpunto gpunto commented May 7, 2026

Goal

Backfill Paparazzi snapshot coverage for Compose components introduced during the
redesigned. Also fixed the typing dot indicator's animation not being deterministic in snapshot
tests.

Implementation

  • Add snapshot tests for: StreamButton, CountBadge, MessageReactions, QuotedMessage.
  • Extend MessageFooterTest with an outgoing thread-start case to cover the MessageAlignment.End
    variant of MessageThreadFooter.
  • Replace System.currentTimeMillis() in TypingDrawable with a ValueAnimator. The drawable now
    implements Animatable and starts/stops via Drawable.setVisible, the standard hook ImageView
    already calls on attach/detach/visibility changes. Add Paparazzi's InstantAnimationsRule to
    PaparazziViewTest so the animator settles to a deterministic frame in tests.

Testing

  • New snapshot tests recorded and pass verifyPaparazziDebug.
  • Existing snapshots that include a ViewAnimator-based animation, now should show a deterministic
    frame the typing indicator. Re-running verifyPaparazziDebug should no longer produces drift.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled (or ignored for dependabot PRs).

🎉 Great job! This PR is ready for review.

@gpunto gpunto added the pr:test Test-only changes label May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.82 MB 5.82 MB 0.00 MB 🟢
stream-chat-android-ui-components 11.02 MB 11.02 MB 0.00 MB 🟢
stream-chat-android-compose 12.38 MB 12.39 MB 0.01 MB 🟢

@gpunto gpunto force-pushed the screenshot-tests branch 4 times, most recently from 9c7c249 to fa0978a Compare May 7, 2026 13:21
Base automatically changed from waveform-slider-fix to develop May 7, 2026 14:22
@gpunto gpunto force-pushed the screenshot-tests branch from 24ba527 to 1ae271a Compare May 7, 2026 15:22
@gpunto gpunto force-pushed the screenshot-tests branch from 1ae271a to 4f729f9 Compare May 7, 2026 15:39
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:test Test-only changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant