Skip to content

Fix missing click handler on thread root #6229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gpunto wants to merge 1 commit into
base: v7
Choose a base branch
from
Open

Fix missing click handler on thread root #6229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...pose/src/main/java/io/getstream/chat/android/compose/ui/messages/list/MessageContainer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
import io.getstream.chat.android.client.utils.message.isGiphy
import io.getstream.chat.android.client.utils.message.isPinned
import io.getstream.chat.android.client.utils.message.isPoll
import io.getstream.chat.android.client.utils.message.isThreadStart
import io.getstream.chat.android.compose.R
import io.getstream.chat.android.compose.state.mediagallerypreview.MediaGalleryPreviewResult
import io.getstream.chat.android.compose.state.messages.MessageAlignment
Expand Down Expand Up @@ -136,7 +137,7 @@
@Suppress("LongMethod")
@OptIn(ExperimentalFoundationApi::class)
@Composable
public fun MessageContainer(

Check failure on line 140 in stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/list/MessageContainer.kt

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 


See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-android&issues=AZzTEx3mdkAOxn-JmMcH&open=AZzTEx3mdkAOxn-JmMcH&pullRequest=6229
messageItem: MessageItemState,
reactionSorting: ReactionSorting,
onLongItemClick: (Message) -> Unit,
Expand Down Expand Up @@ -165,7 +166,7 @@
val clickModifier = Modifier.combinedClickable(
interactionSource = remember { MutableInteractionSource() },
indication = null,
onClick = {},
onClick = { if (message.isThreadStart() && !messageItem.isInThread) onThreadClick(message) },
onLongClick = {
if (!message.isDeleted() && !message.isUploading()) {
haptic.performHapticFeedback(HapticFeedbackType.LongPress)
Expand Down
Loading