Add support for OpenSearch API as ancillary data source #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyh
reviewed
Apr 8, 2021
Member
jeremyh
left a comment
jeremyh
left a comment
There was a problem hiding this comment.
Thanks Callum, looks very clean.
fetch/opensearch.py
Outdated
| Class for data retrievals using the OpenSearch API. | ||
| """ | ||
|
|
||
| def __init__(self, target_dir, api_url, username, password, query, show_progressbars=False, timeout=None, |
Member
There was a problem hiding this comment.
We should set a default timeout, otherwise a network hiccup can leave the spawned task running indefinitely.
See the HTTP sources for an example of a hard-coded default timeout:
Line 245 in 6d4b6f7
Member
There was a problem hiding this comment.
(it's much more important on an ever-running service like fetch than on interactive scripts)
|
Looks good to me. As for a maintainer, there hasn't been much of any dedicated person. Just something that is |
Member
Author
|
Added default connection timeout to OpenSearchApiSource |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jeremyh @dunkgray @sixy6e
Not sure who's maintaining this one at the moment.
Sentinel-1 POEORB and RESORB ancillary recently switched to an OpenSearch API at Copernicus Hub. I've added some support to fetch for this API so we can continue to collect the ancillary.
Please take a look and see whether this is worth merging, and if there's any problems in the approach.