Skip to content

fix(ModelMappings): Added removed_components mapping to follow previo… #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MelchiorSchuh wants to merge 3 commits into
base: next
Choose a base branch
from
+6 −2
Open

fix(ModelMappings): Added removed_components mapping to follow previo… #1272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8a2e34
fix(ModelMappings): Added removed_components mapping to follow previo…
MelchiorSchuh May 18, 2026
6a991a0
Merge branch 'next' of github.com:Geode-solutions/OpenGeode into fix/…
MelchiorSchuh May 19, 2026
5c67f1b
Apply prepare changes
MelchiorSchuh May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions commitlint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const Configuration = {
"type-empty": [0],
"type-enum": [2, "always", ["feat", "fix", "perf"]],
},
}
defaultIgnores: false,
};

export default Configuration
export default Configuration;
3 changes: 3 additions & 0 deletions include/geode/model/representation/core/mapping.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
namespace geode
{
template < typename MappingType >
class ModelMapping

Check warning on line 46 in include/geode/model/representation/core/mapping.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

include/geode/model/representation/core/mapping.hpp:46:11 [cppcoreguidelines-special-member-functions] 

class 'ModelMapping' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor
{
OPENGEODE_DISABLE_COPY( ModelMapping );

Expand Down Expand Up @@ -96,7 +96,7 @@
}

private:
absl::flat_hash_map< ComponentType, Mapping > mappings;

Check warning on line 99 in include/geode/model/representation/core/mapping.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

include/geode/model/representation/core/mapping.hpp:99:55 [readability-identifier-naming] 

invalid case style for private member 'mappings'
};

using ModelCopyMapping = ModelMapping< BijectiveMapping< uuid > >;
Expand All @@ -105,6 +105,8 @@

using ModelAddedComponentMapping = ModelMapping< std::vector< uuid > >;

using ModelRemovedComponentMapping = ModelMapping< std::vector< uuid > >;

using ModelUnchangedComponentMapping = ModelMapping< std::vector< uuid > >;

using MeshElementMapping = GenericMapping< MeshElement, MeshElement >;
Expand Down Expand Up @@ -187,6 +189,7 @@
{
ModelGenericMapping component_mapping;
ModelAddedComponentMapping added_components;
ModelRemovedComponentMapping removed_components;
ModelUnchangedComponentMapping unchanged_components;
};

Expand Down
Loading