Skip to content

fix(Python): missing Component active binding #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 1 commit into from
Mar 20, 2026
Merged

fix(Python): missing Component active binding #1251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bindings/python/src/model/mixin/core/component.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,15 @@
"Component" + std::to_string( dimension ) + "D"; \
pybind11::class_< Component##dimension##D, Identifier, \
pybind11::smart_holder >( module, name##dimension.c_str() ) \
.def( "component_type", &Component##dimension##D::component_type )
.def( "component_type", &Component##dimension##D::component_type ) \
.def( "component_id", &Component##dimension##D::component_id ) \
.def( "is_active", &Component##dimension##D::is_active )

namespace geode
{
void define_component( pybind11::module& module )

Check warning on line 39 in bindings/python/src/model/mixin/core/component.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

bindings/python/src/model/mixin/core/component.cpp:39:10 [misc-use-internal-linkage] 

function 'define_component' can be made static or moved into an anonymous namespace to enforce internal linkage
{
PYTHON_COMPONENT( 2 );

Check warning on line 41 in bindings/python/src/model/mixin/core/component.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

bindings/python/src/model/mixin/core/component.cpp:41:9 [cppcoreguidelines-pro-bounds-pointer-arithmetic] 

do not use pointer arithmetic
PYTHON_COMPONENT( 3 );

Check warning on line 42 in bindings/python/src/model/mixin/core/component.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

bindings/python/src/model/mixin/core/component.cpp:42:9 [cppcoreguidelines-pro-bounds-pointer-arithmetic] 

do not use pointer arithmetic
}
} // namespace geode
Loading