Skip to content

fix(AABB): Added checks on active for model aabb creation #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 3 commits into from
Jan 8, 2026
Merged

fix(AABB): Added checks on active for model aabb creation #1222

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4153922
fix(AABB): Added checks on active for model aabb creation
MelchiorSchuh Jan 5, 2026
da8a9fd
Merge branch 'next' of github.com:Geode-solutions/OpenGeode into fix/…
MelchiorSchuh Jan 5, 2026
4ceebab
Merge branch 'next' of github.com:Geode-solutions/OpenGeode into fix/…
MelchiorSchuh Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions src/geode/model/helpers/aabb_model_helpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,56 +136,66 @@ namespace geode
std::tuple< AABBTree3D, absl::FixedArray< uuid > > create_lines_aabb_tree(
const BRep& model )
{
return create_aabb< 3 >( model.lines(), model.nb_lines() );
return create_aabb< 3 >(
model.active_lines(), model.nb_active_lines() );
}

std::tuple< AABBTree3D, absl::FixedArray< uuid > >
create_surfaces_aabb_tree( const BRep& model )
{
return create_aabb< 3 >( model.surfaces(), model.nb_surfaces() );
return create_aabb< 3 >(
model.active_surfaces(), model.nb_active_surfaces() );
}

std::tuple< AABBTree3D, absl::FixedArray< uuid > > create_blocks_aabb_tree(
const BRep& model )
{
return create_aabb< 3 >( model.blocks(), model.nb_blocks() );
return create_aabb< 3 >(
model.active_blocks(), model.nb_active_blocks() );
}

std::tuple< AABBTree2D, absl::FixedArray< uuid > > create_lines_aabb_tree(
const Section& model )
{
return create_aabb< 2 >( model.lines(), model.nb_lines() );
return create_aabb< 2 >(
model.active_lines(), model.nb_active_lines() );
}

std::tuple< AABBTree2D, absl::FixedArray< uuid > >
create_surfaces_aabb_tree( const Section& model )
{
return create_aabb< 2 >( model.surfaces(), model.nb_surfaces() );
return create_aabb< 2 >(
model.active_surfaces(), model.nb_active_surfaces() );
}

ModelMeshesAABBTree3D create_line_meshes_aabb_trees( const BRep& model )
{
return create_aabbs< 3 >( model.lines(), model.nb_lines() );
return create_aabbs< 3 >(
model.active_lines(), model.nb_active_lines() );
}

ModelMeshesAABBTree3D create_surface_meshes_aabb_trees( const BRep& model )
{
return create_aabbs< 3 >( model.surfaces(), model.nb_surfaces() );
return create_aabbs< 3 >(
model.active_surfaces(), model.nb_active_surfaces() );
}

ModelMeshesAABBTree3D create_block_meshes_aabb_trees( const BRep& model )
{
return create_aabbs< 3 >( model.blocks(), model.nb_blocks() );
return create_aabbs< 3 >(
model.active_blocks(), model.nb_active_blocks() );
}

ModelMeshesAABBTree2D create_line_meshes_aabb_trees( const Section& model )
{
return create_aabbs< 2 >( model.lines(), model.nb_lines() );
return create_aabbs< 2 >(
model.active_lines(), model.nb_active_lines() );
}

ModelMeshesAABBTree2D create_surface_meshes_aabb_trees(
const Section& model )
{
return create_aabbs< 2 >( model.surfaces(), model.nb_surfaces() );
return create_aabbs< 2 >(
model.active_surfaces(), model.nb_active_surfaces() );
}
} // namespace geode