Skip to content

fix(ModelBoundaries): Fixed message to be clearer when having issues … #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 1 commit into from
May 18, 2026
Merged

fix(ModelBoundaries): Fixed message to be clearer when having issues … #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/geode/inspector/topology/brep_blocks_topology.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ namespace geode
"Blocks with non-closed boundary Surfaces"
};
InspectionIssues< index_t > model_boundaries_dont_form_a_closed_surface{
"model boundaries don't form a closed Surface (uuids listed)"
"ModelBoundaries are not valid"
};
InspectionIssues< index_t >
unique_vertex_linked_to_multiple_invalid_surfaces{
Expand Down
4 changes: 2 additions & 2 deletions src/geode/inspector/topology/brep_blocks_topology.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
return false;
}

void create_graph( const geode::BRep& brep,

Check warning on line 118 in src/geode/inspector/topology/brep_blocks_topology.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/inspector/topology/brep_blocks_topology.cpp:118:10 [readability-function-size] 

function 'create_graph' exceeds recommended size/complexity thresholds

Check warning on line 118 in src/geode/inspector/topology/brep_blocks_topology.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/inspector/topology/brep_blocks_topology.cpp:118:10 [readability-function-cognitive-complexity] 

function 'create_graph' has cognitive complexity of 16 (threshold 10)
geode::GenericMapping< geode::uuid, geode::index_t >&
surface_uuids_to_graph_edges,
geode::BijectiveMapping< geode::uuid, geode::index_t >&
Expand Down Expand Up @@ -159,7 +159,7 @@
}
}

std::vector< geode::uuid > find_not_boundary_surfaces(

Check warning on line 162 in src/geode/inspector/topology/brep_blocks_topology.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/inspector/topology/brep_blocks_topology.cpp:162:32 [readability-function-cognitive-complexity] 

function 'find_not_boundary_surfaces' has cognitive complexity of 33 (threshold 10)
const geode::BRep& brep )
{
std::vector< geode::uuid > not_boundaries_surfaces;
Expand Down Expand Up @@ -274,7 +274,7 @@
return dangling_surfaces;
}

bool verify_blocks_boundaries(

Check warning on line 277 in src/geode/inspector/topology/brep_blocks_topology.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/inspector/topology/brep_blocks_topology.cpp:277:10 [readability-function-cognitive-complexity] 

function 'verify_blocks_boundaries' has cognitive complexity of 11 (threshold 10)
const geode::BRep& brep, const geode::Block3D& block )
{
auto polygonal_surface = geode::PolygonalSurface3D::create();
Expand Down Expand Up @@ -322,7 +322,7 @@
== 2;
}

bool are_brep_boundaries_closed( const geode::BRep& brep )

Check warning on line 325 in src/geode/inspector/topology/brep_blocks_topology.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/inspector/topology/brep_blocks_topology.cpp:325:10 [readability-function-cognitive-complexity] 

function 'are_brep_boundaries_closed' has cognitive complexity of 16 (threshold 10)
{
auto polygonal_surface = geode::PolygonalSurface3D::create();
auto polygonal_surface_builder =
Expand Down Expand Up @@ -491,7 +491,7 @@
}

std::optional< std::string > BRepBlocksTopology::
unique_vertex_is_part_of_two_blocks_and_no_boundary_surface(

Check warning on line 494 in src/geode/inspector/topology/brep_blocks_topology.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/inspector/topology/brep_blocks_topology.cpp:494:9 [readability-function-cognitive-complexity] 

function 'unique_vertex_is_part_of_two_blocks_and_no_boundary_surface' has cognitive complexity of 20 (threshold 10)
index_t unique_vertex_index ) const
{
const auto block_uuids = internal::components_uuids(
Expand Down Expand Up @@ -572,7 +572,7 @@
}

std::optional< std::string > BRepBlocksTopology::
vertex_is_part_of_surface_with_wrong_relationships_to_block(

Check warning on line 575 in src/geode/inspector/topology/brep_blocks_topology.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/inspector/topology/brep_blocks_topology.cpp:575:9 [readability-function-cognitive-complexity] 

function 'vertex_is_part_of_surface_with_wrong_relationships_to_block' has cognitive complexity of 13 (threshold 10)
index_t unique_vertex_index,
absl::Span< const uuid > not_boundary_surfaces,
absl::Span< const uuid > dangling_surface ) const
Expand Down Expand Up @@ -630,7 +630,7 @@
}

std::optional< std::string >
BRepBlocksTopology::vertex_is_part_of_invalid_single_surface(

Check warning on line 633 in src/geode/inspector/topology/brep_blocks_topology.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/inspector/topology/brep_blocks_topology.cpp:633:29 [readability-function-cognitive-complexity] 

function 'vertex_is_part_of_invalid_single_surface' has cognitive complexity of 17 (threshold 10)
index_t unique_vertex_index,
absl::Span< const uuid > not_boundary_surfaces ) const
{
Expand Down Expand Up @@ -664,7 +664,7 @@
" is part of only one Surface, which is "
"embedded, but not part of only one Block." );
}
else if( !brep_.Relationships::is_internal(

Check warning on line 667 in src/geode/inspector/topology/brep_blocks_topology.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/inspector/topology/brep_blocks_topology.cpp:667:17 [llvm-else-after-return] 

do not use 'else' after 'return'
surface_id, block_uuids[0] ) )
{
return absl::StrCat( "unique vertex ", unique_vertex_index,
Expand Down Expand Up @@ -699,7 +699,7 @@
}

std::optional< std::string >
BRepBlocksTopology::vertex_is_part_of_invalid_multiple_surfaces(

Check warning on line 702 in src/geode/inspector/topology/brep_blocks_topology.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/inspector/topology/brep_blocks_topology.cpp:702:29 [readability-function-cognitive-complexity] 

function 'vertex_is_part_of_invalid_multiple_surfaces' has cognitive complexity of 17 (threshold 10)
index_t unique_vertex_index ) const
{
const auto line_uuids = internal::components_uuids(
Expand Down Expand Up @@ -824,8 +824,8 @@
{
if( !are_brep_boundaries_closed( brep_ ) )
{
result.model_boundaries_dont_form_a_closed_surface.add_issue( 0,
absl::StrCat( "boundaries are not topologically valid." ) );
result.model_boundaries_dont_form_a_closed_surface.add_issue(
0, "boundaries don't form a valid closed surface." );
}
}
for( const auto unique_vertex_id : Range{ brep_.nb_unique_vertices() } )
Expand Down
Loading