Skip to content

fix(SurfacesTopology): Enacted upgraded tests after fixing other issues. #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MelchiorSchuh wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix(SurfacesTopology): Enacted upgraded tests after fixing other issues. #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 38 additions & 39 deletions src/geode/inspector/topology/brep_surfaces_topology.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,45 +218,44 @@ namespace geode
}
const auto line_uuids = internal::components_uuids(
brep_, unique_vertex_index, Line3D::component_type_static() );
// if( line_uuids.empty() )
// {
// bool has_corner_internal_to_all_surfaces{ false };
// for( const auto& cmv :
// brep_.component_mesh_vertices( unique_vertex_index ) )
// {
// if( cmv.component_id.type()
// != Corner3D::component_type_static() )
// {
// continue;
// }
// const auto& corner = brep_.corner( cmv.component_id.id() );
// for( const auto& surface_id : surface_uuids )
// {
// const auto& surface = brep_.surface( surface_id );
// if( surface.is_active()
// && !brep_.is_internal( corner, surface ) )
// {
// return absl::StrCat( "unique vertex ",
// unique_vertex_index, " at position [",
// corner.mesh().point( cmv.vertex ).string(),
// "] is part of multiple active Surfaces, and not "
// "part of any Line, but is part of Corner ",
// corner.name(), " (", corner.id().string(),
// "), which is not internal to active Surface ",
// surface.name(), " (", surface_id.string(), ")."
// );
// }
// }
// has_corner_internal_to_all_surfaces = true;
// }
// if( !has_corner_internal_to_all_surfaces )
// {
// return absl::StrCat( "unique vertex ", unique_vertex_index,
// " is part of multiple active Surfaces, and not part of "
// "any Line, but not part of any Corner internal to all "
// "Surfaces." );
// }
// }
if( line_uuids.empty() )
{
bool has_corner_internal_to_all_surfaces{ false };
for( const auto& cmv :
brep_.component_mesh_vertices( unique_vertex_index ) )
{
if( cmv.component_id.type()
!= Corner3D::component_type_static() )
{
continue;
}
const auto& corner = brep_.corner( cmv.component_id.id() );
for( const auto& surface_id : surface_uuids )
{
const auto& surface = brep_.surface( surface_id );
if( surface.is_active()
&& !brep_.is_internal( corner, surface ) )
{
return absl::StrCat( "unique vertex ",
unique_vertex_index, " at position [",
corner.mesh().point( cmv.vertex ).string(),
"] is part of multiple active Surfaces, and not "
"part of any Line, but is part of Corner ",
corner.name(), " (", corner.id().string(),
"), which is not internal to active Surface ",
surface.name(), " (", surface_id.string(), ")." );
}
}
has_corner_internal_to_all_surfaces = true;
}
if( !has_corner_internal_to_all_surfaces )
{
return absl::StrCat( "unique vertex ", unique_vertex_index,
" is part of multiple active Surfaces, and not part of "
"any Line, but not part of any Corner internal to all "
"Surfaces." );
}
}
if( line_uuids.size() == 1 )
{
index_t nb_cmv_lines{ 0 };
Expand Down
1 change: 1 addition & 0 deletions tests/inspector/test-solid-adjacency.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ int main()
try
{
geode::InspectorInspectorLibrary::initialize();
geode::Logger::set_level( geode::Logger::LEVEL::debug );
check_adjacency();
check_non_adjacency_no_bijection();
check_non_adjacency_wrong_facet();
Expand Down