Use LevelID as ArcGIS cache gridset's name#961
Use LevelID as ArcGIS cache gridset's name#961initialdmg wants to merge 1 commit intoGeoWebCache:mainfrom
Conversation
|
I agree many tools struggle with gridsets names that are not numeric. It is unfortunate, as the WMTS the specification poses no such constraint, but best to align with what works in practice. However, this change should have a unit or integration test covering the change, please add one. |
722f4db to
b27e5b4
Compare
|
Code committed earlier was an idea, and was not edited in editor, sry for this behaviour. To keep timeline clear, i force pushed the right code and test case, which has passed on my machine. You can review the code now 😃 |
|
Has this PR become stale? Request a rebase as some time has passed. |
|
This is the only outstanding PR that would make a new 1.22.x interesting; but the PR appears stale? |
|
@smithkm what should we do regarding this PR? It's old but seems mergeable. Pheraps it should be rebased to make sure the builds are all still working fine. |
b27e5b4 to
cf52bf9
Compare
Arcgis cache layer extension does not assign any scale name to gridsets, so
GridSetFactorymake it asgridsetName:i, likeEPSG:4326_arcgis:0. This patch uselevelID, like0,1,2..., as scaleName, and it is correspond with our practice in WMTS.