-
Notifications
You must be signed in to change notification settings - Fork 291
FullWMS: support fusing transparent tiles and generating an opaque output #1459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dromagnoli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Only added a question/comment in a test class
| Validator validator = new Validator(result); | ||
| validator.useXMLSchema(true); | ||
| validator.assertIsValid(); | ||
| System.setProperty("http.agent", "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it needed?
what about the validators commented out section ?
(wondering if that was part of a debug session)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I was trying to have the validator use a different user agent, as xlink.xsd was available from a browser.
|
The backport to stderrstdoutTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.27.x 1.27.x
# Navigate to the new working tree
cd .worktrees/backport-1.27.x
# Create a new branch
git switch --create backport-1459-to-1.27.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 5e224a8561a3108494073ed71142aa4ff1cef0dc,15f61b27a765ba19ceec652717157d2ee802553d
# Push it to GitHub
git push --set-upstream origin backport-1459-to-1.27.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.27.xThen, create a pull request where the |
|
The backport to stderrstdoutTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.28.x 1.28.x
# Navigate to the new working tree
cd .worktrees/backport-1.28.x
# Create a new branch
git switch --create backport-1459-to-1.28.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 5e224a8561a3108494073ed71142aa4ff1cef0dc,15f61b27a765ba19ceec652717157d2ee802553d
# Push it to GitHub
git push --set-upstream origin backport-1459-to-1.28.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.28.xThen, create a pull request where the |
In addition I had to comment out yet another Validator usage in tests... the xlink.xsd is not getting downloaded by XMLUnit, even if it's available from the browser. We'll need to rethink that, but for the moment it's mostly a distraction, that class has plenty validators already commented out.