Upgrade build for Java 17 as base Java version #1406

groldan · 2025-05-28T21:19:43Z

Configure maven-enforcer-plugin to require Java 17
Configure maven-enforcer-plugin to require maven 3.8+ as done in GeoServer.
Upgrade github actions workflows to use Java 17
Remove cobertura-maven-plugin (modules/extension/xsd/**), as it is not compatible with Java 11
Update maven-javadoc-plugin configuration to use legacyMode=true and not fail due to module-info.java not present.
Plugin version upgrades:
- jacoco 0.8.7 -> 0.8.13
- maven-checkstyle-plugin 3.3.0 -> 3.6.0
- maven-compiler-plugin 3.11.0 -> 3.14.0
- maven-javadoc-plugin 3.6.3 -> 3.11.2
Add .mvn/jvm.config with necessary --add-exports and --add-opens for internal jdk.compiler packages.

This ensures that build-time tools and compiler plugins interacting with javac internals can function correctly under Java 17's module system.
Centralize maven plugin versions in the root pom's pluginManagement section.

This is a coordinated effort across GeoTools, GeoServer, and GeoWebCache

jodygarnett · 2025-06-25T08:37:40Z

Hey @groldan I am having some feedback when running mvn jetty:run locally:

Failed startup of context o.e.j.m.p.JettyWebAppContext@4e647f39{/geowebcache,file:///Users/jgarnett/dev/gwc/geowebcache/geowebcache/web/src/main/webapp/,UNAVAILABLE}{file:///Users/jgarnett/dev/gwc/geowebcache/geowebcache/web/src/main/webapp/
    ...
    Suppressed: java.lang.RuntimeException: Error scanning entry org/geowebcache/swift/SwiftUploadTask.class from jar file:///Users/jgarnett/.m2/repository/org/geowebcache/gwc-swift/1.28-SNAPSHOT/gwc-swift-1.28-SNAPSHOT.jar
        at org.eclipse.jetty.annotations.AnnotationParser.lambda$parseJar$0 (AnnotationParser.java:882)
        at java.util.TreeMap$ValueSpliterator.forEachRemaining (TreeMap.java:3215)
        at java.util.stream.ReferencePipeline$Head.forEach (ReferencePipeline.java:762)
        at org.eclipse.jetty.annotations.AnnotationParser.parseJar (AnnotationParser.java:874)
        at org.eclipse.jetty.annotations.AnnotationParser.parse (AnnotationParser.java:838)
        at org.eclipse.jetty.annotations.AnnotationConfiguration$ParserTask.call (AnnotationConfiguration.java:163)
        at org.eclipse.jetty.annotations.AnnotationConfiguration$1.run (AnnotationConfiguration.java:471)
        at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob (QueuedThreadPool.java:765)
        at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run (QueuedThreadPool.java:683)
        at java.lang.Thread.run (Thread.java:840)
    Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 61

I am running Java 17, so something is odd:

Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546)
Maven home: /Users/jgarnett/.sdkman/candidates/maven/current
Java version: 17.0.15, vendor: Eclipse Adoptium, runtime: /Users/jgarnett/.sdkman/candidates/java/17.0.15-tem
Default locale: en_CA, platform encoding: UTF-8
OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac"

groldan · 2025-06-25T13:17:31Z

Hi @jodygarnett, good catch, didn't even thought about running mvn jettty:run :/
Should be fixed by 101c362

jodygarnett · 2025-06-25T18:40:54Z

Thanks confirmed the fix worked, note I updated some docs while waiting for builds and so on as part of this PR.

Q: did you force push or anything? My doc changes and commit history seem to be troubled.

groldan · 2025-06-26T01:38:54Z

hi @jodygarnett , sorry about that I'm not used to direct changes to the pr and I'm pretty sure I rebased on top of main hence the force push

jodygarnett

Look exhausting, thanks for the work Gabe. I have tested locally and update the docs.

geowebcache/core/src/main/java/org/geowebcache/layer/TileLayer.java

geowebcache/core/src/main/java/org/geowebcache/service/OWSException.java

geowebcache/core/src/main/java/org/geowebcache/storage/UnsuitableStorageException.java

geowebcache/core/src/main/resources/geowebcache.xml

geowebcache/diskquota/bdb/src/main/java/org/geowebcache/diskquota/bdb/DiskQuotaEntityModel.java

documentation/en/user/source/configuration/layers/howto.rst

aaime · 2025-06-30T08:48:48Z

documentation/en/build.xml

+    <local name="message"/>
+    <property name="message" value="autobuild not available:${line.separator}
+    ${line.separator}
+    virtualenv venv${line.separator}


Wondering if this would work with Windows installations?

On a related note, I've just upgraded to the latest Linux Mint and it's the first distro where I'm basically forced to use virtualenvs, the previous release allowed me to use pip directly.

I don't see why it wouldn't, it's just printing a message and using ${line.separator} for cross platform compatibility.

In any case I'm pretty sure that was Jody's contribution. @jodygarnett do you know if that'll work on windows?

aaime · 2025-06-30T08:51:19Z

documentation/en/user/source/installation/prerequisites/windows.rst

+
+1. Download an OpenJDK release for your platform:
+
+   * https://adoptium.net/temurin/releases/?version=11 Temurin 11 (LTS) (Recommended)


Version 11?

I think you want https://adoptium.net/temurin/releases/?version=17&os=windows&arch=any

The current link is still pointing at java 11 mind

geowebcache/core/src/main/java/org/geowebcache/service/OWSException.java

aaime · 2025-06-30T09:10:51Z

geowebcache/core/src/test/java/org/geowebcache/config/ConfigurationTest.java

                defaultCount + 100,
                getInfoNames(config).size());
        // get a thread pool
+


I don't see the need for these two white lines... the comment refers to the code line below, if anything adding a white line makes it less readable. Maybe you added an annotation and then removed it, leaving an empty line behind?

aaime · 2025-06-30T09:34:21Z

geowebcache/sqlite/src/test/java/org/geowebcache/sqlite/SqliteConnectionManagerTest.java

            throws Exception {
        SqliteConnectionManager connectionManager = new SqliteConnectionManager(poolSize, 10);
        connectionManagersToClean.add(connectionManager);
+


Another newline that I guess is not necessary

aaime · 2025-06-30T09:34:40Z

geowebcache/sqlite/src/test/java/org/geowebcache/sqlite/SqlitlePerf.java

        }
        FileUtils.copyFile(seedFile, databaseFile);
        // submitting the select tasks
+


And various more in this file

aaime · 2025-06-30T09:45:14Z

I pushed changes for the Assert.equals calls having arguments swapped (there's a quick fix for them in IntelliJ)

groldan · 2025-07-08T22:35:51Z

Thanks, squash-merged and ready to merge.

aaime · 2025-07-09T08:19:07Z

Looks like none of my feedback was taken into consideration? Maybe it's just an oversight

* Upgrade build to use Java 17 as the baseline version. * Configure maven-enforcer-plugin to require Java 17. * Upgrade GitHub Actions workflows to use Java 17. * Update documentation for Java 17, including developer and user guides. * Upgrade Jetty from 9.x to 10.0.25, the last version to support `javax.servlet`. * Replace `com.google.common.base.Objects.equal()` with `java.util.Objects.equal()`. * Update test configurations to use `localhost:8080` instead of deprecated demo servers. * Fix REST integration tests and address other issues found during local testing on Java 17. * Increase heap size for the QA build profile. * Fix swapped Assert.equals arguments Plugin version upgrades: * maven-jar-plugin 2.4 -> 3.0.2 * maven-enforcer-plugin 3.0.0-M3 -> 3.5.0 * maven-compiler-plugin 3.10.1 -> 3.14.0 * maven-surefire-plugin 2.22.1 -> 3.5.3 * maven-failsafe-plugin 3.3.1 -> 3.5.3 * maven-war-plugin 3.3.2 -> 3.4.0 * jetty-maven-plugin 9.4.14.v20181114 -> 10.0.25 * maven-javadoc-plugin 3.4.1 -> 3.11.2 * maven-checkstyle-plugin 3.1.1 -> 3.6.0 Co-authored-by: Andrea Aime <andrea.aime@gmail.com> Co-authored-by: Jody Garnett <jody.garnett@gmail.com>

groldan · 2025-07-09T14:31:05Z

Looks like none of my feedback was taken into consideration? Maybe it's just an oversight

Hi Andrea, yes, definitely an oversight. It should be good now.

groldan force-pushed the geoserver3/java17 branch from 0320368 to 5d83fc7 Compare May 28, 2025 22:11

This was referenced May 29, 2025

[GEOS-11845] GSIP-232 Upgrade GeoServer and GeoWebCache Build to Java 17 geoserver/geoserver#8573

Merged

[GEOT-7764] Migrate GeoTools to Java 17 geotools/geotools#5204

Merged

groldan force-pushed the geoserver3/java17 branch 3 times, most recently from a072a7e to 1e4eaf8 Compare June 12, 2025 03:29

groldan marked this pull request as ready for review June 12, 2025 03:35

groldan force-pushed the geoserver3/java17 branch from 1e4eaf8 to d7d3805 Compare June 16, 2025 21:10

groldan force-pushed the geoserver3/java17 branch from 401ed5d to 101c362 Compare June 25, 2025 13:16

jodygarnett mentioned this pull request Jun 26, 2025

geowebcache.xml sample layers reference demo.boundlessgeo.com/geoserver #1418

Open

jodygarnett requested changes Jun 26, 2025

View reviewed changes

groldan force-pushed the geoserver3/java17 branch from ca54fa8 to deb996a Compare June 27, 2025 14:33

aaime reviewed Jun 30, 2025

View reviewed changes

groldan force-pushed the geoserver3/java17 branch from 92239da to 3a8121f Compare July 8, 2025 22:17

groldan force-pushed the geoserver3/java17 branch from 3a8121f to de648b8 Compare July 9, 2025 14:30

groldan merged commit 57bf196 into GeoWebCache:main Jul 9, 2025
9 checks passed

groldan deleted the geoserver3/java17 branch July 9, 2025 19:09

groldan mentioned this pull request Sep 14, 2025

Upgrade codebase to Java 17 language features #1431

Closed


		1. Download an OpenJDK release for your platform:

		* https://adoptium.net/temurin/releases/?version=11 Temurin 11 (LTS) (Recommended)

Upgrade build for Java 17 as base Java version #1406

Upgrade build for Java 17 as base Java version #1406

Uh oh!

Conversation

groldan commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jodygarnett commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

groldan commented Jun 25, 2025

Uh oh!

jodygarnett commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

groldan commented Jun 26, 2025

Uh oh!

jodygarnett left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aaime commented Jun 30, 2025

Uh oh!

groldan commented Jul 8, 2025

Uh oh!

aaime commented Jul 9, 2025

Uh oh!

groldan commented Jul 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

groldan commented May 28, 2025 •

edited

Loading

jodygarnett commented Jun 25, 2025 •

edited

Loading

jodygarnett commented Jun 25, 2025 •

edited

Loading