Skip to content

Docs pdf template#14215

Open
giohappy wants to merge 2 commits into
masterfrom
docs_pdf_template
Open

Docs pdf template#14215
giohappy wants to merge 2 commits into
masterfrom
docs_pdf_template

Conversation

@giohappy
Copy link
Copy Markdown
Contributor

No description provided.

@giohappy giohappy requested a review from Gpetrak May 11, 2026 10:24
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label May 11, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new documentation hook to inject the GeoNode version into the MkDocs configuration and updates the PDF plugin configuration. I have provided a suggestion to make the project root discovery in the new hook more robust by searching for a marker file instead of relying on a hardcoded directory depth.



def on_config(config):
root = Path(__file__).resolve().parents[2]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding the path to the project root with parents[2] is brittle and may break if the file structure changes. A more robust approach would be to dynamically find the project root by searching for a marker file, like manage.py.

Suggested change
root = Path(__file__).resolve().parents[2]
root = next(p for p in Path(__file__).resolve().parents if (p / "manage.py").exists())

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.65%. Comparing base (a9ac0a2) to head (9605d33).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #14215       +/-   ##
===========================================
+ Coverage   43.23%   74.65%   +31.42%     
===========================================
  Files         960      960               
  Lines       58824    58825        +1     
  Branches     8018     8018               
===========================================
+ Hits        25432    43916    +18484     
+ Misses      32113    13108    -19005     
- Partials     1279     1801      +522     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant