Docs pdf template#14215
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new documentation hook to inject the GeoNode version into the MkDocs configuration and updates the PDF plugin configuration. I have provided a suggestion to make the project root discovery in the new hook more robust by searching for a marker file instead of relying on a hardcoded directory depth.
|
|
||
|
|
||
| def on_config(config): | ||
| root = Path(__file__).resolve().parents[2] |
There was a problem hiding this comment.
Hardcoding the path to the project root with parents[2] is brittle and may break if the file structure changes. A more robust approach would be to dynamically find the project root by searching for a marker file, like manage.py.
| root = Path(__file__).resolve().parents[2] | |
| root = next(p for p in Path(__file__).resolve().parents if (p / "manage.py").exists()) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14215 +/- ##
===========================================
+ Coverage 43.23% 74.65% +31.42%
===========================================
Files 960 960
Lines 58824 58825 +1
Branches 8018 8018
===========================================
+ Hits 25432 43916 +18484
+ Misses 32113 13108 -19005
- Partials 1279 1801 +522 🚀 New features to boost your workflow:
|
No description provided.