Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to bypass the is_safe_url security check in the proxy view using a new safe_url keyword argument or a global SAFE_URL_CHECK_ENABLED setting. A critical security issue was identified in geonode/proxy/views.py where the logic for bypassing the check is flawed, potentially leading to a Server-Side Request Forgery (SSRF) vulnerability because the safety check is inadvertently skipped when the safe_url argument is not provided.
45b3638 to
46cf0d0
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #14203 +/- ##
==========================================
+ Coverage 64.82% 66.21% +1.39%
==========================================
Files 960 960
Lines 58865 58871 +6
Branches 8069 8072 +3
==========================================
+ Hits 38159 38982 +823
+ Misses 19083 18240 -843
- Partials 1623 1649 +26 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.