Skip to content

Safe internal URLs#14203

Open
giohappy wants to merge 4 commits intomasterfrom
fix_safe_internal_urls
Open

Safe internal URLs#14203
giohappy wants to merge 4 commits intomasterfrom
fix_safe_internal_urls

Conversation

@giohappy
Copy link
Copy Markdown
Contributor

@giohappy giohappy commented May 7, 2026

No description provided.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label May 7, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a mechanism to bypass the is_safe_url security check in the proxy view using a new safe_url keyword argument or a global SAFE_URL_CHECK_ENABLED setting. A critical security issue was identified in geonode/proxy/views.py where the logic for bypassing the check is flawed, potentially leading to a Server-Side Request Forgery (SSRF) vulnerability because the safety check is inadvertently skipped when the safe_url argument is not provided.

Comment thread geonode/proxy/views.py Outdated
@giohappy giohappy force-pushed the fix_safe_internal_urls branch from 45b3638 to 46cf0d0 Compare May 7, 2026 16:34
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.21%. Comparing base (32ab42e) to head (c434abc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14203      +/-   ##
==========================================
+ Coverage   64.82%   66.21%   +1.39%     
==========================================
  Files         960      960              
  Lines       58865    58871       +6     
  Branches     8069     8072       +3     
==========================================
+ Hits        38159    38982     +823     
+ Misses      19083    18240     -843     
- Partials     1623     1649      +26     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant