Skip to content

[Fixes #11902] Add better support for ISO19115-3:2018 metadata format#14197

Open
cmotadev wants to merge 2 commits intoGeoNode:masterfrom
nds-cprm:master
Open

[Fixes #11902] Add better support for ISO19115-3:2018 metadata format#14197
cmotadev wants to merge 2 commits intoGeoNode:masterfrom
nds-cprm:master

Conversation

@cmotadev
Copy link
Copy Markdown
Contributor

@cmotadev cmotadev commented May 6, 2026

This PR is a proposal to allow GeoNode to set ISO19115-3 (2018) as default metadata format, instead of ISO 19139.

Features:

  • Introduced DefaultMetadataFormatMixin to manage default metadata formats.
  • Updated Catalogue and CatalogueBackend classes to utilize the new mixin for default format and schema.
  • Modified pycsw_http and pycsw_local backends to dynamically set supported formats based on METADATA_FORMATS.
  • Implemented conditional import of MD_Metadata based on the selected metadata format.
  • Created full_metadata_iso19115-3.xml template for ISO19115-3:2018 metadata.
  • Updated settings.py to allow configuration of the default metadata format and template.
  • Adjusted tests to accommodate changes in metadata format handling.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label May 6, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the ISO 19115-3:2018 metadata standard by adding a new XML template, a metadata format mixin, and dynamic backend configuration. Review feedback identified several high-severity issues in the new template, including undefined variables, inverted logic for contact details, syntax errors in template tags, and potential crashes from missing null checks. Suggestions were also made to improve configuration validation in settings.py and to use more specific exception types in the local backend.

Comment thread geonode/catalogue/templates/catalogue/full_metadata_iso19115-3.xml Outdated
Comment thread geonode/catalogue/templates/catalogue/full_metadata_iso19115-3.xml Outdated
Comment thread geonode/catalogue/templates/catalogue/full_metadata_iso19115-3.xml Outdated
Comment thread geonode/catalogue/templates/catalogue/full_metadata_iso19115-3.xml Outdated
Comment thread geonode/catalogue/templates/catalogue/full_metadata_iso19115-3.xml Outdated
Comment thread geonode/catalogue/templates/catalogue/full_metadata_iso19115-3.xml Outdated
Comment thread geonode/catalogue/backends/pycsw_local.py Outdated
Comment thread geonode/catalogue/templates/catalogue/full_metadata_iso19115-3.xml Outdated
Comment thread geonode/catalogue/templates/catalogue/full_metadata_iso19115-3.xml Outdated
Comment thread geonode/settings.py Outdated
@mattiagiupponi mattiagiupponi requested a review from etj May 6, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant