Add dependency for people model in initial migration#14178
Add dependency for people model in initial migration#14178mattiagiupponi wants to merge 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the initial migration for the indexing app to include a dependency on the people app's profile_extra_data migration. A critical error was identified in the migration dependency format, where the migration name incorrectly included the app label prefix. A suggestion has been provided to correct this to ensure the migration runs successfully.
|
|
||
| dependencies = [ | ||
| ("base", "0096_remove_modeltranslation"), | ||
| ("people", "0039_profile_extra_data") |
There was a problem hiding this comment.
The format for migration dependencies is a tuple of (<app_label>, <migration_name>). The migration name you've specified, people.0039_profile_extra_data, is incorrect as it includes the app label prefix. This will cause an error when running migrations, likely a django.db.migrations.exceptions.NodeNotFoundError.
The migration name should be 0039_profile_extra_data.
| ("people", "0039_profile_extra_data") | |
| ("people", "0039_profile_extra_data") |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14178 +/- ##
==========================================
+ Coverage 74.55% 74.57% +0.01%
==========================================
Files 958 959 +1
Lines 58041 58172 +131
Branches 7919 7948 +29
==========================================
+ Hits 43275 43380 +105
- Misses 13000 13028 +28
+ Partials 1766 1764 -2 🚀 New features to boost your workflow:
|
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.