Skip to content

[Fixes #13907] Support for FlatGeoBuf Remote Layers#13908

Open
sijandh35 wants to merge 5 commits intomasterfrom
ISSUE_13907
Open

[Fixes #13907] Support for FlatGeoBuf Remote Layers#13908
sijandh35 wants to merge 5 commits intomasterfrom
ISSUE_13907

Conversation

@sijandh35
Copy link
Contributor

Fixes #13907

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@sijandh35 sijandh35 self-assigned this Jan 26, 2026
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 26, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sijandh35, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances GeoNode's capabilities by integrating support for remote FlatGeoBuf layers. It provides a robust mechanism for GeoNode to consume and manage FlatGeoBuf data hosted externally, including validating the remote source's compatibility with HTTP Range requests and extracting essential geospatial metadata. This addition streamlines the process of incorporating FlatGeoBuf datasets into the GeoNode ecosystem, offering users more flexibility in data management.

Highlights

  • FlatGeoBuf Remote Layer Support: Introduces a new handler to enable the import and management of remote FlatGeoBuf layers within GeoNode.
  • Metadata Extraction via OGR: The new handler leverages OGR with VSICURL to efficiently extract spatial metadata (CRS, BBox, attributes) from remote FlatGeoBuf files using HTTP Range requests.
  • Thumbnail Exclusion for FlatGeoBuf: FlatGeoBuf layers are now explicitly excluded from generating thumbnails, similar to 3D Tiles, to optimize performance and relevance.
  • Comprehensive Unit Tests: New unit tests have been added to ensure the correct functionality of the FlatGeoBuf remote resource handler, covering URL validation and resource creation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for FlatGeobuf remote layers, enhancing GeoNode's capabilities to handle more geospatial data formats. The changes include a new handler for FlatGeobuf, updates to the base model to reflect its properties, and corresponding tests. The implementation correctly integrates FlatGeobuf into the remote resource handling workflow, including URL validation, metadata extraction, and resource creation. The test coverage for the new handler appears comprehensive, covering various scenarios for URL validation and resource creation.

Comment on lines +77 to +78
finally:
range_res.close()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The range_res.close() call is correctly placed in a finally block. However, if requests.get on line 70 fails (e.g., due to a network error or timeout before a response is received), range_res might not be defined, leading to an UnboundLocalError. Consider initializing range_res = None before the try block to prevent this potential issue.

Suggested change
finally:
range_res.close()
try:
range_res = requests.get(url, headers={"Range": "bytes=0-1"}, timeout=10, stream=True)
logger.debug(f"Range GET status: {range_res.status_code}")
if range_res.status_code != 206:
raise ImportException(
"The remote server does not support HTTP Range requests, which are required for FlatGeobuf."
)
finally:
if 'range_res' in locals() and range_res:
range_res.close()

@sijandh35 sijandh35 marked this pull request as ready for review January 30, 2026 08:19
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 84.61538% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.22%. Comparing base (6a35d7e) to head (fb4d562).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13908      +/-   ##
==========================================
+ Coverage   74.19%   74.22%   +0.02%     
==========================================
  Files         944      949       +5     
  Lines       56468    56790     +322     
  Branches     7651     7702      +51     
==========================================
+ Hits        41899    42154     +255     
- Misses      12885    12941      +56     
- Partials     1684     1695      +11     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for FlatGeoBuf Remote Layers

1 participant