DRAFT - Tabulardata

[mattiagiupponi]

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
• New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[gemini-code-assist]

Summary of Changes

Hello @mattiagiupponi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances GeoNode's data ingestion capabilities by introducing comprehensive support for 'tabular' datasets. It specifically addresses the need to properly handle CSV files that may lack traditional spatial geometry, allowing them to be imported, managed, and displayed within the platform. The changes involve updating core data models, refining GeoServer synchronization, and overhauling the CSV upload handler to intelligently classify and process these new data types, thereby expanding the range of data GeoNode can effectively manage.

Highlights

• Tabular Data Support: Introduced a new 'tabular' subtype for datasets, primarily to handle CSV files that do not contain explicit geometry but may include latitude/longitude coordinates or purely non-spatial data.
• Conditional Feature Handling: Implemented conditional logic for 'tabular' datasets regarding style creation, thumbnail generation, and the availability of download and WPS links, ensuring appropriate behavior for non-spatial data.
• CSV Upload Handler Enhancements: Modified the CSV upload handler to automatically detect and classify files without geometry as 'tabular' and adjusted ogr2ogr commands to better parse CSV data types.
• Refactored Resource Management: Refactored several create_geonode_resource and generate_resource_payload methods across various handlers to accept keyword arguments, improving flexibility and allowing the subtype to be dynamically set during resource creation.
• Improved Data Import and Upsert Logic: Enhanced the data import and upsert validation processes, including more precise CRS lookup, robust primary key checks for upserts, and safer geometry handling by adding null checks.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for tabular CSV data in GeoNode. The code changes include adding "tabular" as a subtype for datasets, modifying properties like can_be_downloaded, can_have_wps_links, and can_have_thumbnail to account for tabular data, and introducing a should_create_style property to prevent style creation for tabular data. The sync_instance_with_geoserver function is updated to use fixup_store_type for setting attributes. The CSV handler is modified to detect tabular data based on the presence of geometry fields and set the is_tabular flag in the execution object. Review comments suggest ensuring proper handling of tabular data in code paths that previously relied on style creation, verifying correct attribute handling in fixup_store_type, propagating the is_tabular flag to subsequent tasks, explicitly setting the CRS for tabular data, and validating that the is_tabular parameter is correctly set based on file content.

[mattiagiupponi]

/gemini review

[codecov]

Codecov Report

❌ Patch coverage is 92.85714% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.22%. Comparing base (6a35d7e) to head (2ebb8de).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #13900      +/-   ##
==========================================
+ Coverage   74.19%   74.22%   +0.02%     
==========================================
  Files         944      944              
  Lines       56468    56554      +86     
  Branches     7651     7666      +15     
==========================================
+ Hits        41899    41979      +80     
- Misses      12885    12890       +5     
- Partials     1684     1685       +1     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.