Skip to content

Conversation

@giohappy
Copy link
Contributor

Without this, the sub-packages (geonode.api, etc.) are not packaged and are not available inside the Python path.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 14, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @giohappy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical packaging issue where geonode sub-packages were not being properly included in the Python path. By updating the pyproject.toml configuration, the project's build system will now correctly discover and package all necessary modules, ensuring the application functions as expected.

Highlights

  • Packaging Configuration: Modified the pyproject.toml to correctly include all geonode sub-packages during distribution.
  • Package Discovery: Replaced the explicit packages = ["geonode"] declaration with a dynamic package discovery mechanism using [tool.setuptools.packages.find].

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly addresses the issue of sub-packages not being included in the distribution by switching to a more robust package discovery mechanism in pyproject.toml. This change improves the maintainability and correctness of the package build process.

Comment on lines 182 to +187
include-package-data = true

[tool.setuptools.packages.find]
where = ["."]
exclude = ["tests*"]
include = ["geonode*"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Replacing the explicit packages = ["geonode"] with [tool.setuptools.packages.find] is a good practice for package discovery. This ensures that all sub-packages within the geonode directory, except for tests*, are automatically included in the distribution. This change directly resolves the issue of sub-packages not being packaged, making the build process more reliable and less prone to manual errors when new sub-packages are added.

Suggested change
include-package-data = true
[tool.setuptools.packages.find]
where = ["."]
exclude = ["tests*"]
include = ["geonode*"]
[tool.setuptools.packages.find]
where = ["."]
exclude = ["tests*"]
include = ["geonode*"]

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.20%. Comparing base (5ce993c) to head (ddf6eb5).
⚠️ Report is 49 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13884      +/-   ##
==========================================
+ Coverage   74.07%   74.20%   +0.12%     
==========================================
  Files         932      944      +12     
  Lines       55720    56430     +710     
  Branches     7522     7643     +121     
==========================================
+ Hits        41277    41872     +595     
- Misses      12794    12874      +80     
- Partials     1649     1684      +35     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giohappy giohappy merged commit 948eb49 into master Jan 14, 2026
18 checks passed
@giohappy giohappy deleted the fix_subpackages_packaging branch January 14, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants