-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix packaging of sub-packages #13884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @giohappy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical packaging issue where Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request correctly addresses the issue of sub-packages not being included in the distribution by switching to a more robust package discovery mechanism in pyproject.toml. This change improves the maintainability and correctness of the package build process.
| include-package-data = true | ||
|
|
||
| [tool.setuptools.packages.find] | ||
| where = ["."] | ||
| exclude = ["tests*"] | ||
| include = ["geonode*"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing the explicit packages = ["geonode"] with [tool.setuptools.packages.find] is a good practice for package discovery. This ensures that all sub-packages within the geonode directory, except for tests*, are automatically included in the distribution. This change directly resolves the issue of sub-packages not being packaged, making the build process more reliable and less prone to manual errors when new sub-packages are added.
| include-package-data = true | |
| [tool.setuptools.packages.find] | |
| where = ["."] | |
| exclude = ["tests*"] | |
| include = ["geonode*"] | |
| [tool.setuptools.packages.find] | |
| where = ["."] | |
| exclude = ["tests*"] | |
| include = ["geonode*"] |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13884 +/- ##
==========================================
+ Coverage 74.07% 74.20% +0.12%
==========================================
Files 932 944 +12
Lines 55720 56430 +710
Branches 7522 7643 +121
==========================================
+ Hits 41277 41872 +595
- Misses 12794 12874 +80
- Partials 1649 1684 +35 🚀 New features to boost your workflow:
|
Without this, the sub-packages (geonode.api, etc.) are not packaged and are not available inside the Python path.