[Fixes #13878] Drop useless GS reloads

[giohappy]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @giohappy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issue #13878 by optimizing interactions with the GeoServer catalog. It removes several redundant cat.reload() and cat.reset() calls that were found to be unnecessary after specific operations like dataset creation and cascading deletes. The primary goal is to improve the efficiency and stability of GeoServer catalog management by avoiding superfluous API calls.

Highlights

• GeoServer Catalog Reload Optimization: Removed an unnecessary cat.reload() call within the create_gs_dataset function in geonode/geoserver/createlayer/utils.py. This call was redundant as the catalog state was already consistent after dataset creation.
• Redundant GeoServer Catalog Operations Removal: Eliminated redundant cat.reset() and cat.reload() calls from the finally block of the cascading_delete function in geonode/geoserver/helpers.py. These operations were not required for proper cleanup and could potentially cause performance overhead.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes unnecessary GeoServer catalog reloads, which is a good performance optimization. The changes in geonode/geoserver/createlayer/utils.py and geonode/geoserver/helpers.py correctly identify and remove redundant or overly expensive catalog operations (reload() and reset()). The logic remains correct as subsequent operations will still fetch required data from GeoServer on-demand after the cache is cleared. These changes are sound and improve efficiency.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.18%. Comparing base (5ce993c) to head (95a4094).
⚠️ Report is 45 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #13879      +/-   ##
==========================================
+ Coverage   74.07%   74.18%   +0.10%     
==========================================
  Files         932      944      +12     
  Lines       55720    56398     +678     
  Branches     7522     7632     +110     
==========================================
+ Hits        41277    41840     +563     
- Misses      12794    12879      +85     
- Partials     1649     1679      +30     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.