-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Fixes #13859] Drop requirements.txt and setup.cfg #13860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @giohappy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the project's dependency management by migrating from Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request modernizes the project's dependency management by migrating from requirements.txt and setup.cfg to pyproject.toml. This is a positive change that aligns with current Python packaging standards. My review has identified a critical issue where a dependency was dropped during the migration, which could break the application. I've also included some recommendations to improve the Dockerfile structure and the organization of dependencies within pyproject.toml for better maintainability and adherence to best practices.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13860 +/- ##
===========================================
+ Coverage 52.15% 74.14% +21.98%
===========================================
Files 944 944
Lines 56335 56401 +66
Branches 7626 7632 +6
===========================================
+ Hits 29380 41816 +12436
+ Misses 25588 12908 -12680
- Partials 1367 1677 +310 🚀 New features to boost your workflow:
|
No description provided.