need to remove call to command rebuild_index in tasks.py#11921
need to remove call to command rebuild_index in tasks.py#11921cesarbenjamindotnet wants to merge 7 commits intoGeoNode:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @cesar-benjamin on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #11921 +/- ##
===========================================
+ Coverage 41.33% 63.35% +22.01%
===========================================
Files 865 865
Lines 52291 52291
Branches 6575 6575
===========================================
+ Hits 21617 33130 +11513
+ Misses 29548 17650 -11898
- Partials 1126 1511 +385 |
| # GeoNode org maintained apps. | ||
| django-geonode-mapstore-client>=4.0.5,<5.0.0 | ||
| # django-geonode-mapstore-client==4.0.5 | ||
| django-geonode-mapstore-client @ git+https://github.com/GeoNode/geonode-mapstore-client.git@master#egg=django_geonode_mapstore_client |
There was a problem hiding this comment.
please @cesar-benjamin do not use git versions inside setup.cfg since it breask existing geonode-project (which use their own requirements.txt in turn).
We can consider to adopt your approach, but this must be evaluated in the context of the projects. Maybe in a feature version...
There was a problem hiding this comment.
i do that because for the geonode-project install method, it install geonode as pip package, so, as python packages dependencies uses setup.cfg and not requirements.txt because the usage of setuptools, so, i have to make chages on setup.cfg to can continue the development and tests, etc.
On the other hand i can understand the thing about breaks, i guess can be used the releases approach, using a release tag for get a freeze stable release, and because geonode is moving now, geonode-project need to move along with.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @cesar-benjamin on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
cesarbenjamindotnet
left a comment
There was a problem hiding this comment.
i do that because for the geonode-project install method, it install geonode as pip package, so, as python packages dependencies uses setup.cfg and not requirements.txt because the usage of setuptools, so, i have to make chages on setup.cfg to can continue the development and tests, etc.
On the other hand i can understand the thing about breaks, i guess can be used the releases approach, using a release tag for get a freeze stable release, and because geonode is moving now, geonode-project need to move along with.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @cesar-benjamin on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
when tasks.py is called, after the execution of manage.py in function migrations() there is a try block that use command rebuild_index, this returns the message 'Type "manage.py help' for usage.", i found that this is a haystack command, but haystack was removed after the add of django 4.2 support
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.