Skip to content

Conversation

@bpeng
Copy link
Contributor

@bpeng bpeng commented Jan 11, 2026

Proposed Changes

Changes proposed in this pull request:

  • Add GetWithContext function to allow streaming and handle context cancel

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

@bpeng bpeng requested a review from wilsonjord January 11, 2026 20:06
Copy link
Contributor

@wilsonjord wilsonjord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sue-h-gns sue-h-gns merged commit 5750ac9 into main Jan 11, 2026
8 checks passed
@sue-h-gns sue-h-gns deleted the s3-context branch January 11, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants