Skip to content

Conversation

@EvanCGNS
Copy link
Contributor

Updated location code 42 on NZA, NZB, NZC, and NZE to match the data from the BPRs.

Timestamps
NZA: 2023-12-15T22:00:00Z,2025-12-16T21:59:45Z
NZB: 2023-12-06T15:00:00Z, current (end of file was corrupted)
NZC: 2023-12-08T23:00:00Z,2025-12-07T22:59:45Z
NZE: 2023-12-11T02:00:00Z,2025-12-10T20:59:45Z

@EvanCGNS EvanCGNS self-assigned this Jan 22, 2026
@EvanCGNS EvanCGNS requested review from a team and ozym as code owners January 22, 2026 02:05
@EvanCGNS EvanCGNS added the dart DART based work label Jan 22, 2026
@salichon
Copy link
Contributor

"NZB: 2023-12-06T15:00:00Z, current (end of file was corrupted)"
Is there a way to document "the absence of data" -as we re going to forget this corrupted file in few years
?

@ozym
Copy link
Contributor

ozym commented Jan 22, 2026

Delta installs should reflect the times of potential data, rather than actual data. This is to avoid becoming a holdings database.

There might be a chance data is recovered, or that it was collected in real time.

To address issues related to usability we tend to work with streams. That is the bpr derived streams may reflect what was recovered, but the gauge installations reflect ship logs or visit times etc.

This is to avoid questions about gaps.

@EvanCGNS
Copy link
Contributor Author

Delta installs should reflect the times of potential data, rather than actual data. This is to avoid becoming a holdings database.

There might be a chance data is recovered, or that it was collected in real time.

To address issues related to usability we tend to work with streams. That is the bpr derived streams may reflect what was recovered, but the gauge installations reflect ship logs or visit times etc.

This is to avoid questions about gaps.

I'm a little confused, should any changes be made to this PR then?

Copy link
Contributor

@salichon salichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For NZE the last data is to me 2025-12-10T20:59:45Z 107.64786 9.01079 72.124 so 72 meters as i can see
Check the BPR dates again to find the most sensible data at least on that one.

@salichon
Copy link
Contributor

@EvanCGNS
dates are okay for NZA, NZC
Last data for the BPR NZB "raw" is 2025/10/25 16:00 ( we can discuss if this stands somewhere relevant)
It looks like you took only dates for the last data time almost that but not for NZE
cheers

@salichon
Copy link
Contributor

and for NZB @EvanCGNS
Let s base our time assumption on
"There might be a chance data is recovered, or that it was collected in real time."
as Mark mentioned indeed.
so time NZB is relevant enough,

@EvanCGNS
Copy link
Contributor Author

Good spotting @salichon about NZE. I have 2025-12-10T18:54:15Z as the ending timestamp now, I'll update the PR

Updated location code 42 on NZA, NZB, NZC, and NZE to match the data from the BPRs.

Timestamps
NZA: 2023-12-15T22:00:00Z,2025-12-16T21:59:45Z
NZB: 2023-12-06T15:00:00Z, unchanged (end of file was corrupted)
NZC: 2023-12-08T23:00:00Z,2025-12-07T22:59:45Z
NZE: 2023-12-11T02:00:00Z,2025-12-10T18:54:15Z
@EvanCGNS EvanCGNS force-pushed the update-DART-timestamps branch from 764dce8 to fb4d2f6 Compare January 23, 2026 03:03
@EvanCGNS EvanCGNS requested a review from salichon January 23, 2026 03:03
@EvanCGNS
Copy link
Contributor Author

@salichon and @ozym the PR is ready for re-review

@EvanCGNS EvanCGNS merged commit 8f449b1 into main Jan 23, 2026
18 checks passed
@EvanCGNS EvanCGNS deleted the update-DART-timestamps branch January 23, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dart DART based work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants