fix(server): add GET /observations endpoint for plugin compatibility#336
Open
Wild-sergunys wants to merge 1 commit intoGentleman-Programming:mainfrom
Open
Conversation
Added GET /observations route that reuses handleRecentObservations handler. Updated DOCS.md with the new endpoint. Added test coverage for the new route with and without sort parameter. Closes Gentleman-Programming#288
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added GET /observations endpoint that reuses handleRecentObservations handler.
Why
The save-nudge plugin sends GET /observations?project=...&limit=1&sort=created_at:desc
but the server only had POST /observations, returning 405 Method Not Allowed.
The plugin silently failed because curl -sf suppresses error output.
How
GET /observationspointing tohandleRecentObservationsTesting
main:curl -s -w "\nHTTP_CODE: %{http_code}\n" "..."-> 405 Method Not AllowedTestHandleGetObservationsWithSortpassesCloses #288