-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Sort transcript data output #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
korikuzma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test case + update docstrings with sorted results comment if not already included (quick look)
|
@korikuzma We don't need to add a test case for this (I think), since this was a fix in the function call that was used in |
I do think we should have a test case since the bug was caused by this method using unsorted results. This would help prevent this issue from happening again in the future |
|
@korikuzma The added test is for this example you had identified. When I run the function that is called by VarCat, I get the following output: ProteinAndCdnaRepresentation(protein=DataRepresentation(gene='CDKN2A', refseq='NP_000068.1', ensembl='ENSP00000307101.5', pos=(57, 58), strand=<Strand.NEGATIVE: -1>, status=<TranscriptPriority.MANE_SELECT: 'mane_select'>), cdna=CdnaRepresentation(gene='CDKN2A', refseq='NM_000077.5', ensembl='ENST00000304494.10', pos=(171, 172), strand=<Strand.NEGATIVE: -1>, status=<TranscriptPriority.MANE_SELECT: 'mane_select'>, coding_start_site=30, coding_end_site=501, alt_ac='NC_000009.12')) |
closes #451