Skip to content

Conversation

@jarbesfeld
Copy link
Contributor

closes #451

@jarbesfeld jarbesfeld self-assigned this Jan 22, 2026
@jarbesfeld jarbesfeld requested a review from a team as a code owner January 22, 2026 21:17
@jarbesfeld jarbesfeld added bug Something isn't working priority:medium Medium priority labels Jan 22, 2026
katie-perry
katie-perry previously approved these changes Jan 22, 2026
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test case + update docstrings with sorted results comment if not already included (quick look)

@jarbesfeld
Copy link
Contributor Author

jarbesfeld commented Jan 22, 2026

@korikuzma We don't need to add a test case for this (I think), since this was a fix in the function call that was used in mane_transcript.py. I included a docstring to explain the sorting rationale.

@jsstevenson jsstevenson changed the title fix!: Sort transcript data output fix: Sort transcript data output Jan 23, 2026
@korikuzma
Copy link
Member

@korikuzma We don't need to add a test case for this (I think), since this was a fix in the function call that was used in mane_transcript.py. I included a docstring to explain the sorting rationale.

I do think we should have a test case since the bug was caused by this method using unsorted results. This would help prevent this issue from happening again in the future

@jarbesfeld
Copy link
Contributor Author

@korikuzma The added test is for this example you had identified. When I run the function that is called by VarCat, I get the following output:

ProteinAndCdnaRepresentation(protein=DataRepresentation(gene='CDKN2A', refseq='NP_000068.1', ensembl='ENSP00000307101.5', pos=(57, 58), strand=<Strand.NEGATIVE: -1>, status=<TranscriptPriority.MANE_SELECT: 'mane_select'>), cdna=CdnaRepresentation(gene='CDKN2A', refseq='NM_000077.5', ensembl='ENST00000304494.10', pos=(171, 172), strand=<Strand.NEGATIVE: -1>, status=<TranscriptPriority.MANE_SELECT: 'mane_select'>, coding_start_site=30, coding_end_site=501, alt_ac='NC_000009.12'))

@jarbesfeld jarbesfeld requested a review from korikuzma January 23, 2026 13:47
@jarbesfeld jarbesfeld requested a review from korikuzma January 23, 2026 15:44
@jarbesfeld jarbesfeld merged commit 7e3a95d into main Jan 23, 2026
14 checks passed
@jarbesfeld jarbesfeld deleted the issue-450 branch January 23, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority:medium Medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants