Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Media SDK PtzCoordinatesManagerSample to align the zoom/iris/focus direction comments and example arguments with the SDK PTZ contract.
Changes:
- Corrected
StartZoomdirection comment and updated the example argument value. - Corrected
StartIrisdirection comment and updated the example argument value. - Corrected
StartFocusdirection comment and updated the example argument value.
Comments suppressed due to low confidence (2)
Samples/Media SDK/PtzCoordinatesManagerSample/PtzCoordinatesManagerSample.cs:172
- These
ControlPtzcalls mix a named argument (commandType:) with subsequent positional arguments, which is not valid C# (positional arguments cannot follow named ones). Use either fully positional arguments or namearg1:/arg2:as well; also consider applying the same fix to the corresponding StopZoom call for consistency/compilation.
// arg1: Zoom direction (0 for zoom in, 1 for zoom out)
// arg2: Zoom speed (0 to 100)
manager.ControlPtz(commandType: PtzCommandType.StartZoom, 0, 50);
await Task.Delay(2000, token); // Wait for 2 seconds before stopping zoom
manager.ControlPtz(commandType: PtzCommandType.StopZoom, 0, 0);
Samples/Media SDK/PtzCoordinatesManagerSample/PtzCoordinatesManagerSample.cs:187
- These
ControlPtzcalls mix a named argument (commandType:) with subsequent positional arguments, which will not compile in C#. Switch to either fully positional arguments or namearg1:/arg2:as well (and align the corresponding StopIris call too).
// arg1: Iris direction (0 for open iris, 1 for close iris)
// arg2: Iris adjustment speed (0 to 100)
manager.ControlPtz(commandType: PtzCommandType.StartIris, 0, 50);
await Task.Delay(2000, token); // Wait for 2 seconds before stopping iris
manager.ControlPtz(commandType: PtzCommandType.StopIris, 0, 0);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation