Figure.pygmtlogo: Remove the additional black outline for the black-and-white dark-theme logo#4638
Open
seisman wants to merge 2 commits into
Open
Figure.pygmtlogo: Remove the additional black outline for the black-and-white dark-theme logo#4638seisman wants to merge 2 commits into
seisman wants to merge 2 commits into
Conversation
Member
|
The outline is nice from a visual perspective, but from a consistency perspective, I prefer to remove this outline. I never really liked it, because it affects the size of the logo or the thickness of the surrounding shape. |
Member
Author
|
I've remove the black outline, and also updated the baseline image with a gray background. |
Contributor
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Report last updated at commit ad98a38 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Currently, we add an additional black outline to the black-and-white logo in dark theme. But is it really necessary? Dark mode usually implies a dark (black) background, and the white shape outline is already visually distinct from the background (see below).